Skip to content

test: fix live preview test closing its dialog on Qt 6 #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PierreRaybaut merged 1 commit into from
Oct 5, 2026
Merged

test: fix live preview test closing its dialog on Qt 6 #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions datalab/tests/features/common/processing_preview_unit_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,11 +856,16 @@ def test_live_image_to_signal_preview(tmp_path, monkeypatch):
assert expected.x.size == 8
dialog = ProcessingPreviewDialog(param, line_profile, [source])
loop = QW.QApplication.instance()

def stop_loop(*_args) -> None:
# Unlike quit(), exit() does not close top-level windows with Qt 6
loop.exit()

timeout = QC.QTimer()
timeout.setSingleShot(True)
timeout.timeout.connect(loop.quit)
dialog.preview.controller.SIG_RESULT.connect(loop.quit)
dialog.preview.controller.SIG_ERROR.connect(loop.quit)
timeout.timeout.connect(stop_loop)
dialog.preview.controller.SIG_RESULT.connect(stop_loop)
dialog.preview.controller.SIG_ERROR.connect(stop_loop)
dialog.show()
executor = None
try:
Expand Down
Loading