Repository navigation
Describe segment profiles sampled end point to end point - #440
Merged
Merged
Conversation
Segment profiles are now sampled at regular steps from their start point to their end point included, with one sample per pixel along the axis where the segment spans the most pixels (DataLab-Platform/Sigima#101): they were sampled in steps of the smallest distance between pixel centers, which could omit the end point and allocate huge arrays. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion of DataLab-Platform/Sigima#102 (closes DataLab-Platform/Sigima#101), same branch name.
Summary
Sigima now samples segment profiles at regular steps from their start point to their end point included, with one sample per pixel along the axis where the segment spans the most pixels (as in Sigima 1.3). Since DataLab-Platform/Sigima#98, they were sampled in steps of the smallest distance between pixel centers, which could omit the end point (e.g. the last pixel of a diagonal) and allocate huge arrays for images with a tiny pixel spacing.
doc/features/image/menu_analysis.rst: description of the segment profile updated.sphinx_intl update: no change).No code change: the profile dialog and parameters are unchanged.
Validation
fix/segment-profile-sampling:profile_app_test.py,provenance_processing_unit_test.py,provenance_capture_unit_test.pypass (39).