Repository navigation
Signal auto downsampling: apply the configured maximum to all curves - #456
Merged
Merged
Conversation
…lected ones
Since v1.0.0, changing the auto downsampling or line width settings only
refreshed the curves of the selected signals (`manual_refresh()`): the
other curves kept the former settings, even once selected again, and
dialogs made from them (`make_item(update_from=...)`) inherited them.
- New `BasePlotHandler.update_existing_items()`, which updates all
existing plot items from their objects and the current settings, without
changing their visibility nor adding shape items again (unlike
`refresh_plot("existing")`)
- Settings: call it when `sig_autodownsampling*` or `sig_linewidth*`
options change
- Settings dialog: actual default maximum number of points (100,000
instead of 10,000) and clearer help
- New tests of the settings applied to unselected curves, of shape items
and visibility, and of plot items made for dialogs
Requires DataLab-Platform/SigimaX#31 (downsampling threshold).
Closes #455
Assisted-by: Claude Opus 5.5
Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #455.
Depends on DataLab-Platform/SigimaX#31 (downsampling threshold), which closes DataLab-Platform/SigimaX#30. The DataLab CI tests this PR against the SigimaX branch of the same name.
Problems
sig_autodownsampling*orsig_linewidth*settings calledmanual_refresh(), which only refreshes the selected signals:make_item(update_from=...)) inherited the stale settings.Changes
Settings applied to all curves
BasePlotHandler.update_existing_items():refresh_plot("existing"), it neither changes the visibility of the items nor adds the shape items again.DLMainWindow.__edit_settingscalls it when asig_autodownsampling*orsig_linewidth*option changes, instead ofmanual_refresh().Settings dialog
Documentation and translations
build/lib/datalabadds unrelated stale strings.Before / after
Number of points drawn, with only the 2M-point signal selected when the settings are changed:
Tests
datalab/tests/features/signal/autodownsampling_unit_test.py, covering, through the Settings action:features/signal,features/commonandbackbone: 838 passed, 1 skipped.maxpoints + 2points drawn).