Repository navigation
Stop persisting the plot watermark path - #463
Merged
Merged
Conversation
DataLabOptions set watermark_image_path to the absolute path of the watermark image of the running installation, but the field kept the "view" category inherited from SigimaX, so it was written to the user configuration and, on the next start, overrode the value of whichever DataLab read this configuration. Installations sharing it (e.g. DataLab installed in several Python environments) displayed the watermark of the first one, no watermark once it was removed, and a blurry one on high-DPI screens when it predated the @2x images. - options: the watermark path is now uncategorized application branding, like the splash screen image, hence never persisted. - persistence: OBSOLETE_INI_OPTIONS lists the INI options written by earlier versions that are removed when the configuration is loaded ([view] watermark_image_path, written by DataLab 1.3). - Regression test: a stale watermark path is ignored, removed from the INI file and not written back. Assisted-by: Claude Opus 5.5
Add the 1.4.0 bug-fix note on the watermark of empty plots read from another installation sharing the user configuration, and its French translation. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop persisting the path of the plot watermark image in the user configuration, and remove the obsolete
[view] watermark_image_pathkey written by DataLab 1.3 when the configuration is loaded.options.py: the watermark path is uncategorized application branding (like the splash screen image), hence never persisted.persistence.py: newOBSOLETE_INI_OPTIONSremoved byload_options_from_ini(also covers the legacy configuration migration).Companion SigimaX PR (independent, not required by this one): resolution of watermark image names, see DataLab-Platform/SigimaX#35.
Closes #462