Repository navigation
Sharp splash screen and watermark on high-DPI displays - #34
Merged
Merged
Conversation
Load the splash screen and plot watermark images with guidata's get_pixmap, which uses their @2x high-resolution variant (if any) to display them at the resolution of the screen, instead of letting Qt upscale an image rendered for a 100% display scaling. The fallback splash screen is also drawn at the resolution of the screen. Refs #33 Assisted-by: Claude Opus 5.5
Refs #33 Assisted-by: Claude Opus 5.5
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33 (related: DataLab-Platform/DataLab#460, PlotPyStack/guidata#121).
With a display scaling greater than 100% (e.g. 125%), the splash screen and the watermark of empty plots were blurry: their image was loaded as a pixmap rendered for a 100% scaling, which Qt upscaled.
Changes
SigimaXSplashScreen) and the plot watermark (SigimaXPlotWidget) images are loaded withguidata.configtools.get_pixmap(Sharp images and scaled text with Windows display scaling PlotPyStack/guidata#122), which uses their@2xhigh-resolution variant (e.g.splash@2x.pngnext tosplash.png), if any, to display them at the resolution of the screen. Without variant, the behavior is unchanged.get_pixmapis available in guidatadevelop/master(merged in PlotPyStack/guidata#122); the minimum guidata version required by SigimaX is left unchanged for now and will be raised once guidata is released.Tests
test_splash_uses_hidpi_variant; the fallback test now checks the logical size of the pixmap.