fix: preserve Responses recovery across Helm relays - #972
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Responses continuation loses its original upstream WebSocket, the remote Helm knows the turn was not sent and asks the client to resend full history. A second Helm currently loses that signal when it receives a recovery disconnect, reports an unknown execution outcome, and blocks recovery.
Helm relays now request structured recovery errors and retain the reason and cooldown across SSE and HTTP error responses. Direct Codex clients keep their existing recovery disconnect behavior. Bare connection closures still remain non-replayable unknown outcomes; both Helm hops must be upgraded for the fix to take effect.
Validation: red-to-green regression with real local WebSockets, 362 focused provider/connector/bridge tests passed, shared/core/gateway typechecks passed, scoped Biome checks passed. Independent read-only P0/P1 review found no actionable issues. Production verification follows release deployment.