Repository navigation
feat: shared navbar/footer partials + Packages nav + add Sebastian Funk to team - #26
Merged
Merged
Conversation
… chrome) Hand-rolled Bootstrap navbar and footer matching the site's config-driven chrome, as the single source the separate tutorials site renders via a submodule rather than duplicating. Includes a tiny active-state script.
…stian Funk to team - navbar 'Docs' -> 'Packages', moving it ahead of 'Tutorials' (applies to the main _quarto.yml and the shared navbar.html partial so the tutorials submodule stays in step) - team page: add Sebastian Funk (github.com/sbfnk, scoringrules work)
📄 Site preview builtThe rendered site for this PR is available as the site-preview artifact on this run. Download it and open |
The config navbar/page-footer in _quarto.yml duplicated _includes/navbar.html and _includes/footer.html, and the two had already drifted (different Tutorials target). Make the partials the only chrome definition, consumed by both this site and the tutorials site's submodule copy. - Remove website.navbar and website.page-footer from _quarto.yml; inject the partials via format.html.include-before-body/ include-after-body instead. - Add website.search: true so Quarto still emits search.json and the quarto-search JS/assets with no navbar/sidebar config driving them. - Add a `#quarto-search` div to navbar.html; quarto-search.js hydrates any element with that id regardless of where it lives in the DOM. Each site sets search: true independently, so results stay per-site. - Extend the active-link script to match location.pathname against each nav link's own absolute href on the main site (previously only the tutorials host got active-state handling), including dropdown parents. - Add Sebastian Funk's LSHTM profile link to team.qmd, matching Sam Abbott's card (verified 200: lshtm.ac.uk/aboutus/people/ funk.sebastian). Verified with a full `quarto render`: exactly one navbar and one footer per page at every depth (root, approaches/, news/posts/), search.json/site_libs/quarto-search assets present, nav/footer/logo links resolve correctly at depth (Quarto rewrites the root-relative logo src per page depth; nav links are already absolute so they are unaffected by depth).
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
_includes/navbar.htmland_includes/footer.htmlthe single definition of the ecosystem chrome, and consumes them on this site._includes/navbar.html,_includes/footer.html): hand-rolled Bootstrap navbar and footer. The separate tutorials site renders these same two files via a submodule, so the chrome exists once.website.navbarandwebsite.page-footerare deleted from_quarto.yml; the partials are injected viaformat.html.include-before-body/include-after-body. Without this the partials would have been a second, hand-maintained copy used only by tutorials, which is what an earlier revision of this PR did.website.search: trueis what makes Quarto emitsearch.jsonandsite_libs/quarto-search/*; it does not require a navbar or sidebar. The partial supplies its own<div id="quarto-search">, whichquarto-search.jshydrates by id. Search is per-site: each site sets the flag and indexes its own content.location.pathname, marking the current link and its dropdown parent.tutorials.epiaware.org.Supersedes #24, which pointed the Tutorials entry at
tutorials.epiaware.orgin the config navbar this PR deletes. Close #24 when this merges.Merge order: this PR first. EpiAware/tutorials#3 pins a submodule commit from this branch, so once this lands on
mainthat pin must be repointed to themaincommit before #3 merges.Verified with a real
quarto render: exactly one navbar and one footer per page across all 18 pages, search assets and index emitted, one#quarto-searchdiv per page, logo path resolving correctly at every directory depth.This was opened by a bot. Please ping @seabbs for any questions.