Skip to content

chore!: require Node.js 24 or later #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vigneshrajsb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore!: require Node.js 24 or later #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ brave-falcon-7 building acme/api#88 fix/timeout jdoe

## Installation

Requires Node ≥ 20.
Requires Node ≥ 24.

```bash
npm install -g lfc-cli
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"LICENSE"
],
"engines": {
"node": ">=20"
"node": ">=24"
},
"scripts": {
"build": "tsup",
Expand Down
4 changes: 2 additions & 2 deletions src/lib/doctor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,12 @@ function permissionCheck(args: {

function nodeVersionCheck(): DoctorCheck {
const major = Number(process.versions.node.split('.')[0]);
const ok = major >= 20;
const ok = major >= 24;
return {
id: 'node_version',
label: 'node',
status: ok ? 'ok' : 'error',
message: ok ? `node ${process.version}` : `node ${process.version}; expected >=20`,
message: ok ? `node ${process.version}` : `node ${process.version}; expected >=24`,
};
}

Expand Down
2 changes: 1 addition & 1 deletion tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { defineConfig } from 'tsup';
export default defineConfig({
entry: ['src/index.ts'],
format: 'esm',
target: 'node20',
target: 'node24',
clean: true,
banner: {
// shebang + createRequire shim so bundled CJS deps can require() node builtins from ESM
Expand Down
Loading