[FIX] UI: remove unintended Prompt\IsPromptContent - #11853
Open
thibsy wants to merge 1 commit into
Open
Conversation
The `Modal\Roundtrip` and `Dropzone\File` components inherited `Prompt\IsPromptContent` unintendedly by `Form\Standard`, which was parent class of both. To remove these components from being valid prompt content, the inheritance was changed from `Input\Container\Form\Standard` to `Input\Container\Container`. To minimise breaking changes, the `withSubmitLabel()` was added to the `Modal\RoundTrip` explicitly.
thibsy
added
php
Contributor
Author
|
For anyone who shepherds this: please only perform a review, I will handle integration myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
The
Modal\RoundtripandDropzone\Filecomponents inheritedPrompt\IsPromptContentunintendedly byForm\Standard, which was parent class of both.To remove these components from being valid prompt content, the inheritance was changed from
Input\Container\Form\StandardtoInput\Container\Container. To minimise breaking changes, thewithSubmitLabel()was added to theModal\RoundTripexplicitly. This path was chosen to omit thePrompt\IsPromptContentfrom being inherited, while still offering the data processing options of an input container, as I believe they were more widely used.There are four usages of
Modal\RoundTripused asPrompt\IsPromptContentinsideILIAS\MetaData\OERHarvester\ControlCenter\ControlCenterGUI. @schmitz-ilias, how would you like to proceed?Kind regards,
@thibsy