Repository navigation
Avoid false shallow-water barriers from depth roundoff - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interpolating an exactly 2 m seabed can produce values such as -1.9999999999999998, causing valid water to become disconnected and yielding short recovery routes or failed onward planning. Apply a 1e-9 m arithmetic tolerance consistently to swept depth checks and shallow/coastal masks while retaining the configured minimum depth, exclusion buffer, and rejection of unknown terrain.
Validation: all 98 routing tests pass, including regressions that accept boundary roundoff and reject a measurable shallow violation or unknown depth. The same resident terrain produces a checked 2.4 km forward route with the correction.