Repository navigation
fix: skip GUI camera requests in server-only launches - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
posim_robot.launch.pyenables the ocean-waves GUI camera move even whengui:=falseorheadless:=true. There is no GUI camera service in that mode, so each run makes an unnecessary request and printsService call timed out.Change
Enable
zoom_cameraonly forposim_ocean_wavesand a non-server-only launch. One file changes. The existing GUI camera pose, delay, world and robot configuration remain unchanged.Independent validation
Base:
23bb608a9a89b9cda3472792316a81711f1ce73e; freshposim_demosoverlay only. Linux ARM64 Docker on Apple M2, ROS 2 Lyrical / Gazebo Jetty. No input, plugin-shutdown or ros_gz overlay.gui:=false headless:=falselaunch: no camera service request/timeout.gui:=true headless:=truelaunch: no camera service request/timeout.gui:=true headless:=false, default 2 s delay), rendered via software OpenGL on Xvfb: automatic camera service returneddata: true;/gui/camera/posereported the requested position (-1, 0, 0.5). A subsequent camera move and restoration were confirmed by pose messages and screenshots.The GUI test is Linux GUI in a virtual display, not native macOS/Metal. Stock
ros_gz_bridgestill segfaulted during teardown in these three standalone launches; this small camera-condition change neither includes nor claims the separate upstream shutdown fix.Reproduce the affected path
Before: camera request times out. After: no GUI camera request. With GUI enabled and headless disabled, the camera move is retained.
Please review; no merge or release is requested by this validation run.
CI infrastructure note (2026-10-08)
ARM64 run 37743089211 stopped in the runner-admin pre-job hook, before checkout/build: ~61.09 GiB free vs its 80 GiB minimum. This is not a compiler/test result for this change. No runner files, free-space thresholds, or maintenance hooks were changed. ARM64 CI remains unverified until the runner is ready; the Docker workflow does not publish PR images.