Repository navigation
fix: keep DVL water-mass layers within sensor ranges - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Four DVL descriptors set the water-mass far boundary to 100 m even though their declared maximum ranges are smaller. Gazebo rejects these tracking settings before the affected DVLs can publish data.
Fix
Use each descriptor's existing maximum range as the far boundary: 75, 81, 66 and 90 m for Nortek DVL1000-300, Teledyne Explorer1000, Explorer4000 and WHN, respectively. No sensor range or noise specification is increased. Add a pytest regression for the eight Gazebo DVL configurations and a catalog-presence check.
Validation
main(50f3a5e) with the new regression: 4 failed / 5 passed; failures identify exactly the four affected descriptors.posim_sensor_modelsbuilds and its colcon tests pass on Linux ARM64 / ROS 2 Lyrical.Run after building the package:
colcon test --merge-install --packages-select posim_sensor_models colcon test-result --verboseThis corrects invalid configuration, not physical DVL accuracy. Other architectures remain for CI/reviewer validation.