Skip to content

fix: preserve subsecond timestamps in derived depth messages - #19

Merged
woensug-choi merged 1 commit into
mainfrom
fix/pressure-depth-stamp-20261009
Oct 10, 2026
Merged

woensug-choi merged 1 commit into
mainfrom
fix/pressure-depth-stamp-20261009

Conversation

@yeseorizi

Copy link
Copy Markdown
Collaborator

Stacked on #15. The base is fix/ros-plugin-shutdown-20261008 so the review diff contains only the depth timestamp fix and its test. Retarget to main after #15 is merged, preserving this small diff.

Problem

The pressure message includes seconds and nanoseconds, but its derived depth message copied only whole seconds from the measurement time. For example, measurements at 0.125 s and 0.325 s both produced a depth timestamp of zero.

Fix

Copy the pressure message's full header to the depth message generated from that same measurement. Pressure, variance, depth values and topic names are unchanged.

Validation

  • New ROS/Gazebo plugin regression receives both messages at 125 ms and 325 ms, checks identical timestamps, and checks the existing pressure, variance and depth values.
  • The isolated timestamp change builds and passes the timestamp regression plus five camera tests on Linux ARM64 / ROS 2 Lyrical / Gazebo Jetty.
  • The final stack with fix: guard ROS plugin updates during context shutdown #15 passed all seven cases (five camera, one pressure shutdown, one timestamp). Replacing the pressure implementation with unchanged main failed both new pressure regressions; restoring the fix passed all seven again.

This is message-timestamp consistency, not a claim of physical pressure-sensor accuracy or all-platform validation. No merge is requested before CI and review.

Base automatically changed from fix/ros-plugin-shutdown-20261008 to main October 10, 2026 06:17
@woensug-choi
woensug-choi merged commit 1459547 into main Oct 10, 2026
1 check passed
@woensug-choi
woensug-choi deleted the fix/pressure-depth-stamp-20261009 branch October 10, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants