Repository navigation
fix: preserve subsecond timestamps in derived depth messages - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #15. The base is
fix/ros-plugin-shutdown-20261008so the review diff contains only the depth timestamp fix and its test. Retarget tomainafter #15 is merged, preserving this small diff.Problem
The pressure message includes seconds and nanoseconds, but its derived depth message copied only whole seconds from the measurement time. For example, measurements at 0.125 s and 0.325 s both produced a depth timestamp of zero.
Fix
Copy the pressure message's full header to the depth message generated from that same measurement. Pressure, variance, depth values and topic names are unchanged.
Validation
mainfailed both new pressure regressions; restoring the fix passed all seven again.This is message-timestamp consistency, not a claim of physical pressure-sensor accuracy or all-platform validation. No merge is requested before CI and review.