Repository navigation
fix: quote POSIX world paths at launch entry points - #20
Merged
woensug-choi merged 1 commit intoOct 10, 2026
Merged
Conversation
Generated-by: OpenAI Codex Signed-off-by: yeseorizi <172019512+yeseorizi@users.noreply.github.com>
5 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The world and robot launch entry points pass an unquoted world filename through
gz_argsto the shell-based Gazebo launcher. An installed package share containing spaces (for example, a native macOS application data directory) is consequently split into multiple arguments, and the selected world cannot load.Change
posim_world.launch.pyandposim_robot.launch.py.empty.sdfcase, and Windows command construction.ament_cmake_pytest.Validation
/bin/shand compare the received filename, including spaces, apostrophes, Unicode, and shell metacharacters. They also check Windows command construction and empty-world flags.colcon build/colcon testfor posim_demos only pass; changed-file pre-commit hooks pass.Related boundary: quoting the
gzexecutable itself is handled by ros_gz #980; this PR fixes the separate world filename argument. If both paths contain spaces, both fixes are needed.Not claimed: Windows execution or fixes, Linux AMD64 validation, or a complete packaged-app/robot-demo acceptance test.
AI assistance: OpenAI Codex was used to prepare the patch, tests, and this description; the checks above were executed locally.