Repository navigation
[docker] Bump bundled Trivy to 0.76.1 and disable its update check - #376
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull Request
📖 Description
The Dockerfile now bundles Trivy v0.76.1 pinned by tag and digest, and the Trivy servers in the two compose files run the same version, so the
--protection from #367 runs on the binary it was measured on. v0.76.1 sends an update check with a host identifier tocheck.trivy.devon every scan, so the image setsTRIVY_SKIP_VERSION_CHECK=trueandTRIVY_DISABLE_TELEMETRY=true; the provider's arguments are unchanged. The #367 cases were re-run against the pinned image's binary withTRIVY_SERVERpointing at a closed port: without--the target is read as an option, with--each of the three option-like targets is treated as an image name and no file is read, and a normal target takes the normal scan path. The area documents and decision records 0005, 0015 and the new 0016 are updated. This is a chore that touches Docker/build configuration.🎫 Issues
Closes #372
Decision records: 0005, 0015 (edited in place, unreleased), 0016 (new).
💬 Reviewer Notes
The change has no production or test code. The pin and the measurements could not use
docker pull(no Docker daemon): the image index was fetched by digest frommirror.gcr.iobecauseregistry-1.docker.ioanswered 429, and the binary was extracted from its layers. Please check that the image still pulls in CI or on a host with Docker.📑 Test Plan
No unit tests: nothing in the C# code changes. Verified by measurement: digest and layers, static
trivy --version0.76.1, the four #367 cases plus the normal path and an unknown tag understrace, and a control run showing thecheck.trivy.devlookup that the two variables remove. hadolint, scope check and decision check pass.✅ Checklist
.squad/stack.md, and the Analyzer gate reports no diagnostic in a changed file..squad/stack.mdpasses (line coverage on new or changed production code and overall).README.md,ARCHITECTURE.md) to reflect my changes..squad/stack.mdprescribes.csharp.instructions.mdare followed.⏭ Next Steps
None.