Repository navigation
fix(ci): repair op-bench after graph_random_walk signature change - #245
Merged
Merged
Conversation
native/op_bench.c: pass the new avoid_cycles arg (0) — the harness keeps measuring the same op, so base/head results stay comparable. The benchmark job went red on #244 because the runner's merge-ref (new store sources + old harness) failed to compile. Co-Authored-By: Claude Code <noreply@anthropic.com>
Contributor
Per-op benchmark — p50 cycles (base vs head)base runs: 5, head runs: 5 (median of mins) · freq-correction ×0.9987 · threshold head−base > max(40 cyc, 5%)
* head frequency-corrected to base via the No regressions beyond threshold. |
This was referenced Oct 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
benchmarkjob went red on #244. Root cause: avoidCycles (#243) added an argument tograph_random_walk, butnative/op_bench.cstill used the old 8-arg call — the runner's merge-ref (new store sources + old harness) failed to compile. Reproduced locally; the pre-change tree builds and benches fine.native/op_bench.c: pass the newavoid_cyclesarg (0) — the harness keeps measuring the same op, so base/head stay comparableVerified locally:
make -C native benchcompiles, runs, emits the JSON report (exit 0). On this PR the base-build step self-skips (base lacks the harness fix); the full base-vs-head comparison resumes on the next PR.Follow-up note: the head-build step currently sends
makeoutput to/dev/null, which made the red run undebuggable — a one-step fix to print the build-log tail on failure is prepared locally but held back: pushing workflow files requires a token withworkflowscope.🤖 Generated with Claude Code