Repository navigation
docs(ui): sync Mobile UI skills to MMDS RN 0.54.0 and drop the Storybook MCP dependency - #212
Draft
georgewrmarshall wants to merge 1 commit into
Draft
georgewrmarshall wants to merge 1 commit into
georgewrmarshall wants to merge 1 commit into
Conversation
…ook MCP dependency
Refresh the metamask-mobile overlays of ui-development, component-scaffold,
and content-guidelines against @metamask/design-system-react-native 0.54.0,
@metamask/design-system-twrnc-preset 0.13.0, and @metamask/design-tokens
12.0.0 (MMDS release v77.0.0). Add a pinned reference with the export
inventory, key props, tokens, type scale, and hero typography rules.
- Mark ButtonHero, ButtonFilter, and FontFamily.Accent as deprecated
- Use ButtonBase twClassName={(pressed) => ...}; style is not a function
- Remove the useElevatedSurface helper, which no longer exists in Mobile
- Read component docs from GitHub at the release tag; Storybook MCP is optional
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
8 of 11 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This brings the MetaMask Mobile UI skills up to date with the latest published MetaMask Design System (MMDS) release. It also removes their dependency on Storybook MCP, which goes down whenever Context Forge does. Extension is handled in #213. Neither PR depends on the other, and the two merge cleanly in either order.
Synced to
mainpin@metamask/design-system-react-native^0.54.0@metamask/design-system-twrnc-preset^0.13.0@metamask/design-tokens^12.0.0@metamask/design-system-sharedMMDS release/tag: v77.0.0 (2026-10-28, commit
697dc5dc). Every fact was checked against the published npm tarballs (dist/*.d.cts) and the source at that tag, not againstmain. Stable doc links point atblob/v77.0.0/....Release notes I was asked to verify, checked against the code
FontFamily.Accentwere removedmainin #1645 (merged after v77.0.0). In 0.54.0 / shared 0.43.0,FontFamily.Accentand the twrncfont-accent-*classes still exist. The skills treat Accent as "do not use; it breaks on the next upgrade".FontFamily.HeroFontFamily.Heroalready existed (MM Poly) and was switched to Grotzec Cond Bold in RN 0.52.0 (#1586).Textforcesfont-hero-boldfor Hero whateverfontWeightsays, andfont-hero-regularwas removed.TextVariant.AmountDisplayLgAmountDisplayLgpredates Grotzec. It is a size variant, not hero-only. 0.52.0 changed it to 48/56 and addedTextVariant.DisplayXl(60/75). Hero comes fromfontFamily, not the variant.MarketingMomentTitle.utils.tsallowlistsde, en, es, fr, id, pt, tl, tr. Mobile ships 15 languages, and the other seven are exactly el, hi, ja, ko, ru, vi, zh. Those get the iOSSystem/ AndroidRobotoface at weight 700, one Display size down. Formatted numbers are not gated.Changes per skill
ui/ui-development,repos/metamask-mobile.mdButtonHeroandButtonFilterfrom the "required imports" list and adds them, plusFontFamily.Accent, to the conversion table and review checklist.ButtonBase.styleisStyleProp<ViewStyle>, sostyle={({ pressed }) => ...}fails type-checking. Pressed styles now usetwClassName={(pressed) => ...}.AmountDisplayLgfor the primary amount,MarketingMomentTitlefor translated headlines), and the Latin-only locale fallback.TextFieldSearchrequiresinputAccessibilityLabel(0.54.0), andCardrequiresisInteractiveto be pressable (0.50.0). Also addstoast()usage (Mobile mounts<Toaster />once) and notes that the sheet surface isbg-elevated1by default.Boxhas noborderRadiusprop, even though its README documents one.ui/ui-development, newreferences/mmds-react-native.mdui/component-scaffold,repos/metamask-mobile.mduseElevatedSurface()step. That helper no longer exists in Mobile (app/util/theme/themeUtilsis gone), and MMDSBottomSheetDialogappliesbg-elevated1itself.Foo.tsxtemplate and the pressed-state snippet so they use theButtonBase twClassNamefunction. Also drops the unusedBox/useTailwindimports.locales/languages/en.jsonat the repo root (there is noapp/locales), and theAccessRestrictedModalimport example no longer imports the removed helper.ui/content-guidelines,skill.mdandrepos/metamask-mobile.md#content-guidelinesanchor).CHANGELOG.md: one entry under Unreleased / Changed.Things I wasn't sure about
FontFamily.Accent: I documented it as "exported in 0.54.0 but removed onmain; do not use". Once the next MMDS release ships #1645, the reference needs a version bump.tabular-nums, a number glyph gate, andDisplayMdhero titles.BoxREADME documents a nonexistentborderRadiusprop, the RNTextREADME lists 10 of 15 variants, and the sharedfontFamilyJSDoc still says "Hero: MM Poly". The skill says "types win". These look worth fixing upstream.ScrollView-in-BottomSheetgotcha and the other non-MMDS Mobile rules were kept as they were. I did not re-verify them beyond the paths above.Related: Extension and Storybook MCP changes are in #213.
Type of Change
Skill Details (if adding a new skill)
N/A. This updates existing skills (
ui/ui-development,ui/component-scaffold,ui/content-guidelines) and their Mobile overlays.Provider Name: N/A
Skill Name: N/A
Brief Description: N/A
Checklist
Testing
yarn test: 73/73 passyarn lint(changelog): passesnode .github/scripts/lint-skill-entry.mjs <changed files>(what CI runs): 0 errors. The 5 "missing recommended section" warnings were already onmain. A fullyarn audit:skillsstill reports 1 error in the unrelatedtypescript/tsc-blindspotsskill, which is also onmainand not touched here../tools/install --repo metamask-mobile --domain uiinto a scratch repo installsmms-ui-development(withreferences/mmds-react-native.mdnext toSKILL.md),mms-component-scaffold, andmms-content-guidelines. The relativereferences/...links resolve after install.Additional Context
Sources: the published npm tarballs (
npm pack), the MMDS repo atv77.0.0, and MetaMask Mobilemainate9688c9(2026-11-02) forMarketingMomentTitle, locales, the Toaster mount, and the removeduseElevatedSurface.