Repository navigation
docs(ui): make Extension UI skill and DS strategy work without Storybook MCP - #213
Draft
georgewrmarshall wants to merge 1 commit into
Draft
georgewrmarshall wants to merge 1 commit into
georgewrmarshall wants to merge 1 commit into
Conversation
…ook MCP Context Forge outages take Storybook MCP down, and the Extension ui-development overlay required it. Agents now read the installed @metamask/design-system-react types and component READMEs at the MMDS release tag, backed by a pinned reference for design-system-react 0.49.0 and design-system-tailwind-preset 0.15.0 (MMDS release v77.0.0). Storybook MCP is documented as an optional extra. Update the agentic design system strategy to match: skills must work with no MCP server, and may carry a small release-pinned reference. Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
7 of 11 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context Forge is down, and Storybook MCP goes down with it. The Extension
ui-developmentoverlay made Storybook MCP its required first step, so it is broken right now. This PR makes the Extension skill and the agentic design system strategy work with no MCP server, and keeps Storybook MCP as an optional extra for when it comes back.Mobile is handled in #212, which also removes the Storybook MCP pointer from
content-guidelines. The two PRs are independent and merge cleanly in either order.Synced to
mainpin@metamask/design-system-react^0.47.0(0.47.x)@metamask/design-system-tailwind-preset^0.15.0@metamask/design-tokens^12.0.0@metamask/design-system-shared^0.41.0MMDS release/tag: v77.0.0 (2026-10-28). I checked against the published tarballs and the source at that tag. I also diffed 0.47.0 against 0.49.0: the exported components are identical. The only API change Extension code would hit is the breaking
TextFieldSearch.inputAriaLabelin 0.49.0, which the reference calls out.Changes per file
ui/ui-development,repos/metamask-extension.mdblob/v77.0.0URL pattern), then the pinned reference, then the Extension Tailwind config, then Extension usage. Storybook MCP (storybook-broker-mcp) comes last, as optional: use it if it responds, never block on it, and don't configure it.ButtonHero→Button,ButtonFilter,FontFamily.Accent) and the legacyui/components/component-library→ MMDS direction, with a link to the ReactMIGRATION.md.Textvariants, Hero only for the primary amount or throughMarketingMomentTitle) and accessible names (ButtonIcon ariaLabel,TextFieldSearch inputAriaLabelfrom 0.49.0).ui/ui-development, newreferences/mmds-react.mds-/md:l-typography classes, no default palette). It also covers the full web type scale (HTML tag, both breakpoints, weight), web hero typography (Bold-only@font-face, no locale gate in Extension so the browser falls back per character,AmountDisplayLgat 60px for 768px and up, skeletonh-14 md:h-[75px]), and a do/don't table.ui/knowledge/agentic-design-system-strategy.mdCHANGELOG.md: one entry under Unreleased / Changed. It sits at the end of the list so it doesn't conflict with #212.Other skills that pointed at Storybook MCP or Context Forge:
ui/content-guidelinesis fixed in #212. A repo-wide search found no other skill that requires Storybook MCP or Context Forge.testing/mobile-testingsays "check Storybook" for local stories, which doesn't involve MCP, so I left it alone.Things I wasn't sure about
ButtonFilterhas no React replacement. The React 0.49.0 JSDoc says "UseFilterButtoninstead", but@metamask/design-system-reactdoesn't exportFilterButton; only React Native has it. The skill says to keep existing usage and record a gap for new UI. This probably needs an MMDS fix.FontFamily.Accent/font-accentare still exported in 0.49.0 and preset 0.15.0, but removed onmain(#1645). The skill says not to use them.^0.47.0vs 0.49.0). The reference is written for 0.49.0 and lists the deltas. On 0.47.x,TextFieldSearchhas noinputAriaLabel, so the skill says to useinputProps['aria-label']there.AmountDisplayLgon full-screen web (768px and up) is what the tokens produce. The attached draft guideline lists it as an open design question, so the skill says to confirm it with design.metamask.github.io/metamask-design-system) is public and doesn't depend on Context Forge, but it builds frommain. I listed it only as optional, with that caveat.references/mmds-*.mdon each MMDS release. An owner or automation for that is worth agreeing on.font-s-heading-lg sm:font-l-heading-lg) doesn't match what the preset generates (text-s-heading-lg ... md:text-l-heading-lg). The skill uses the generated names.Type of Change
Skill Details (if adding a new skill)
N/A. This updates the existing
ui/ui-developmentExtension overlay and theuidomain knowledge file.Provider Name: N/A
Skill Name: N/A
Brief Description: N/A
Checklist
Testing
yarn test: 73/73 passyarn lint(changelog): passesnode .github/scripts/lint-skill-entry.mjs <changed files>(what CI runs): 0 errors, 1 knowledge file checked. The 2 "missing recommended section" warnings onui-developmentwere already onmain. A fullyarn audit:skillsstill reports 1 error in the unrelatedtypescript/tsc-blindspotsskill, which is also onmain../tools/install --repo metamask-extension --domain uiinto a scratch repo installsmms-ui-developmentwithreferences/mmds-react.md. The mergedSKILL.mdmentions Storybook MCP only as optional.Additional Context
Extension facts were checked against
MetaMask/metamask-extensionmain:package.jsonpins,tailwind.config.js,ui/css/utilities/fonts.scss(the Grotzec@font-face), andui/components/ui/marketing-moment-title.