Skip to content

fix: remove duplicate reward episode metrics - #1570

Merged
TATP-233 merged 1 commit into
mainfrom
fix/issue-1569-remove-episode-reward-metrics
Sep 14, 2026
Merged

TATP-233 merged 1 commit into
mainfrom
fix/issue-1569-remove-episode-reward-metrics

Conversation

@TATP-233

@TATP-233 TATP-233 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Removed RewardManager._episode_sums and its per-term episode accumulation.
  • Stopped emitting Episode_Reward/<term> reset extras, eliminating the duplicate TensorBoard reward tree.
  • Preserved reward/<term> step metrics and stateful reward-term reset calls.
  • Updated manager tests to assert that reset extras contain no episode reward metrics while reset IDs still reach stateful terms.

Linked Work

Validation

  • make test-all passed on the final local head before this PR was created or updated
  • Additional task-specific validation listed below

Commands actually run:

uv run pytest tests/managers/test_core_managers.py -q
uv run ruff format --check src/unilab/managers/reward_manager.py src/unilab/envs/manager_based_rl_env.py tests/managers/test_core_managers.py
uv run ruff check src/unilab/managers/reward_manager.py src/unilab/envs/manager_based_rl_env.py tests/managers/test_core_managers.py
git diff --check
make check
make test
make test-all

Remote CI route:

Impact

  • Backend impact: none
  • Platform impact: none
  • Training effect expected: yes — TensorBoard per-term logs are reduced to reward/<term> only; policy input/output and optimization behavior are unchanged.

Artifacts

  • W&B: none
  • benchmark result: none
  • video / screenshot: none
  • ONNX / checkpoint: none

Checklist

  • Added or updated tests where needed
  • Updated docs if behavior or workflow changed
  • Linked the driving issue
  • Noted any follow-up work explicitly

@TATP-233
TATP-233 merged commit 0982633 into main Sep 14, 2026
8 checks passed
@TATP-233
TATP-233 deleted the fix/issue-1569-remove-episode-reward-metrics branch September 14, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove duplicate Episode_Reward per-term TensorBoard metrics

1 participant