fix: remove duplicate reward episode metrics - #1570
Merged
Merged
Conversation
This was referenced Sep 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RewardManager._episode_sumsand its per-term episode accumulation.Episode_Reward/<term>reset extras, eliminating the duplicate TensorBoard reward tree.reward/<term>step metrics and stateful reward-term reset calls.Linked Work
mainValidation
make test-allpassed on the final local head before this PR was created or updatedCommands actually run:
uv run pytest tests/managers/test_core_managers.py -q uv run ruff format --check src/unilab/managers/reward_manager.py src/unilab/envs/manager_based_rl_env.py tests/managers/test_core_managers.py uv run ruff check src/unilab/managers/reward_manager.py src/unilab/envs/manager_based_rl_env.py tests/managers/test_core_managers.py git diff --check make check make test make test-allRemote CI route:
main: all current-head checks passed for commit8f0319c773aebbf20f17b2383c10e2c175d0c637.Impact
reward/<term>only; policy input/output and optimization behavior are unchanged.Artifacts
Checklist