fix(cloudxr): update nvidia.github.io/IsaacTeleop links to IsaacCapture - #1144
Merged
Merged
Conversation
The GitHub repo was renamed NVIDIA/IsaacTeleop -> NVIDIA/IsaacCapture and its GitHub Pages site moved from nvidia.github.io/IsaacTeleop/ to nvidia.github.io/IsaacCapture/. GitHub Pages does not redirect old-name URLs the way it redirects the repo itself, so every hardcoded nvidia.github.io/IsaacTeleop link now 404s. This broke test-teleop-ros2's live CloudXR bring-up smoke test, which downloads the web client from WEB_CLIENT_BASE at that URL, cascading into a wheel-gate failure on every PR. Update WEB_CLIENT_BASE, the Sphinx doc-build's web client URL, and every other hardcoded nvidia.github.io/IsaacTeleop reference (READMEs, example script docstrings, CI workflow messages) to the new IsaacCapture Pages address. github.com/NVIDIA/IsaacTeleop links are left as-is since GitHub auto-redirects those for the renamed repo. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Gareth Morgan <gmorgan@nvidia.com>
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA/IsaacCapture/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (25)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughWorkflow preview URLs, documentation links, example references, and setup guidance now use IsaacCapture paths instead of IsaacTeleop paths. The CloudXR web client base changed to the IsaacCapture path, and its versioned-client URL tests now expect that path. Deployment logic, version-slug construction, and CloudXR check and exit behavior remain unchanged. Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The updated CloudXR and preview URLs match the checked-in Pages deployment paths. No actionable merge-blocking risk is evident. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
nv-jakob
approved these changes
Sep 29, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The GitHub repo was renamed
NVIDIA/IsaacTeleop→NVIDIA/IsaacCapture, and its GitHub Pages site moved fromnvidia.github.io/IsaacTeleop/tonvidia.github.io/IsaacCapture/. GitHub Pages doesn't redirect old-name URLs the way GitHub redirects the repo itself, so every hardcodednvidia.github.io/IsaacTeleoplink now 404s — this currently breaks CI on every open PR.What changed
src/python/isaaccapture/cloudxr/oob_teleop_env.py:WEB_CLIENT_BASEnow points atnvidia.github.io/IsaacCapture/client/— this is the actual CI-breaking fix.test-teleop-ros2's "Verify live CloudXR bring-up" step downloads the web client from this URL; with the old host it 404s, and that failure cascades intowheel-gatefailing on every PR.docs/source/conf.py: the Sphinx-generated web client URL and its RST link target now use the new Pages address.tests/python/core/cloudxr/test_oob_teleop_env.py: updated expected-URL assertions to match.nvidia.github.io/IsaacTeleopreferences repo-wide (README.md, example script docstrings underexamples/mcap_record_replay/, plugin/example READMEs,src/compat/isaacteleop.py, and the two docs-preview/deploy GitHub Actions workflows) updated to the new host, since they're all now dead links.github.com/NVIDIA/IsaacTeleop/...links (the repo itself, not Pages) are left untouched — GitHub auto-redirects those for the renamed repo, so they still work.Validation
uv run pytest tests/python/core/cloudxr/test_oob_teleop_env.py— 45/45 passingSKIP=check-copyright-year pre-commit run --files <changed files>— all hooks passmake current-docs(samesphinx-build -W --keep-goingas CI) — builds clean with no warnings; verified the generatedquick_start.htmlnow links tonvidia.github.io/IsaacCaptureKnown limitations / follow-ups
None — this is a mechanical link-fix scoped to the Pages-URL breakage.
Test plan
test-teleop-ros2andwheel-gateCo-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Summary by CodeRabbit