Repository navigation
Conversation
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <krish@nvidia.com>
…ngine-image-media Signed-off-by: krishung5 <krish@nvidia.com> # Conflicts: # tensorrt_llm/grpc/openengine/capabilities.py # tensorrt_llm/grpc/openengine/request_mapping.py # tensorrt_llm/inputs/media_io.py # tests/unittest/grpc/openengine/test_multimodal.py # tests/unittest/inputs/test_url_validation.py
Signed-off-by: krishung5 <krish@nvidia.com>
# Conflicts: # tensorrt_llm/grpc/openengine/capabilities.py # tensorrt_llm/grpc/openengine/request_mapping.py # tensorrt_llm/inputs/media_io.py # tests/unittest/grpc/openengine/test_multimodal.py # tests/unittest/grpc/openengine/test_multimodal_conformance.py # tests/unittest/inputs/test_url_validation.py
Signed-off-by: krishung5 <krish@nvidia.com>
Signed-off-by: krishung5 <43719498+krishung5@users.noreply.github.com>
…ngine-audio-media Signed-off-by: krishung5 <43719498+krishung5@users.noreply.github.com> # Conflicts: # tensorrt_llm/grpc/openengine/capabilities.py # tensorrt_llm/grpc/openengine/request_mapping.py # tensorrt_llm/grpc/openengine/server.py # tests/unittest/grpc/openengine/test_multimodal.py # tests/unittest/grpc/openengine/test_multimodal_conformance.py # tests/unittest/grpc/openengine/test_openengine.py
Signed-off-by: krishung5 <43719498+krishung5@users.noreply.github.com>
Signed-off-by: krishung5 <43719498+krishung5@users.noreply.github.com>
Signed-off-by: krishung5 <43719498+krishung5@users.noreply.github.com>
Signed-off-by: krishung5 <43719498+krishung5@users.noreply.github.com>
|
/bot run |
|
PR_Github #80682 [ run ] triggered by Bot. Commit: |
Signed-off-by: krishung5 <43719498+krishung5@users.noreply.github.com>
|
PR_Github #80682 [ run ] completed with state
|
Signed-off-by: krishung5 <43719498+krishung5@users.noreply.github.com>
Signed-off-by: krishung5 <43719498+krishung5@users.noreply.github.com>
Signed-off-by: krishung5 <43719498+krishung5@users.noreply.github.com>
Signed-off-by: krishung5 <43719498+krishung5@users.noreply.github.com>
|
/bot run |
|
PR_Github #80993 [ run ] triggered by Bot. Commit: |
|
PR_Github #80993 [ run ] completed with state
|
|
/bot run |
👎 Promotion blocked, new vulnerability foundVulnerability report
|
Signed-off-by: krishung5 <43719498+krishung5@users.noreply.github.com>
|
/bot run |
|
PR_Github #81087 [ run ] triggered by Bot. Commit: |
kaiyux
left a comment
There was a problem hiding this comment.
Approving on behalf of trt-llm-models-devs, thx
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
|
PR_Github #81087 [ run ] completed with state |
Signed-off-by: krishung5 <43719498+krishung5@users.noreply.github.com> # Conflicts: # tensorrt_llm/grpc/openengine/request_mapping.py # tests/unittest/grpc/openengine/test_multimodal.py # tests/unittest/grpc/openengine/test_multimodal_conformance.py
|
/bot run |
|
PR_Github #81211 [ run ] triggered by Bot. Commit: |
Description
Add audio inputs to the OpenEngine gRPC Generate path.
Stacked on video PR #20654. The image-input prerequisite #20446 is merged into main. This PR does not depend on image performance #21037 or image routing #21125.
UUID forwarding is covered by mapper tests. Engine-side UUID use depends on the model supporting multimodal hashing; Whisper disables that path, so its conformance test does not claim UUID/cache-identity coverage.
Test Coverage
Local validation of branch refresh
8fb1e663d:These runs used a TensorRT-LLM 1.4.0rc0 release container with the merged Python sources installed. They do not replace matching-build upstream validation. Confirm the A10 conformance stage and shared model/audio fixtures against the published PR head before merge.
Related Issues
PR Checklist
Dev Engineer Review
Generate.UNAVAILABLE.LLM_MODELS_ROOTwas unavailable.QA Engineer Review
test_multimodal.pyinl0_cpu.yml.test_multimodal_conformance.pyinl0_a10.yml.Per-File QA Perspective
tensorrt_llm/grpc/openengine/capabilities.py: Adds model-aware media capability resolution and placeholder formatting. Verify unsupported modalities and malformed templates.tensorrt_llm/grpc/openengine/control.py: Reports supported modalities and token-ID support throughGetModelInfo. Verify default and multimodal responses.tensorrt_llm/grpc/openengine/errors.py: AddsMediaUnavailableError. Verify exports and gRPC status mapping.tensorrt_llm/grpc/openengine/request_mapping.py: Adds media loading, validation, ordering, limits, cancellation, and token-ID checks. Verify all input-source paths and cleanup behavior.tensorrt_llm/grpc/openengine/servicer.py: Adds capability caching, request registration, duplicate detection, and media error handling. Verify abort and cleanup paths.tensorrt_llm/grpc/openengine/server.py: Closes the media HTTP session during shutdown, including shutdown failures. Verify lifecycle cleanup.tensorrt_llm/inputs/media_io.py: Adds byte loading, DNS-safe fetching, retry classification, and decoded-memory reservations. Verify limits and reservation cleanup.tensorrt_llm/inputs/model_config.py: Adds shared model-type resolution. Verify class-level and instance-level fallbacks.tensorrt_llm/inputs/utils.py: Routes media loading through safe HTTP fetching. Verify image, video, and audio regressions.tensorrt_llm/serve/chat_utils.py: Uses the shared model-type resolver. Verify existing chat behavior.tensorrt_llm/_torch/models/modeling_whisper.py: Declares that Whisper does not support token-ID input. Verify Whisper validation.tests/integration/test_lists/test-db/l0_a10.yml: Addstest_multimodal_conformance.pyto the A10 list.tests/integration/test_lists/test-db/l0_cpu.yml: Addstest_multimodal.pyto the CPU list.tests/unittest/grpc/openengine/test_control.py: Covers multimodal model-info and token-ID capability reporting. The file has no direct test-list entry shown.tests/unittest/grpc/openengine/test_multimodal.py: Covers media mapping, limits, cancellation, validation, and gRPC errors. Listed inl0_cpu.yml.tests/unittest/grpc/openengine/test_multimodal_conformance.py: Covers real image, video, and audio generation. Listed inl0_a10.yml.tests/unittest/inputs/test_async_media_loading.py: Covers raw-byte loading, session lifecycle, and video decoder arguments. The file has no direct test-list entry shown.tests/unittest/inputs/test_model_config.py: Covers model-type resolution. The file has no direct test-list entry shown.tests/unittest/inputs/test_url_validation.py: Covers DNS, timeout, HTTP, redirect, and response-size behavior. The file has no direct test-list entry shown.tests/unittest/_torch/modeling/test_modeling_whisper.py: Covers Whisper processor capabilities. The file has no direct test-list entry shown.tests/unittest/inputs/test_video_decode.py: Covers decoded-video limits and reservation cleanup. The file has no direct test-list entry shown.tests/unittest/grpc/openengine/test_openengine.py: Verifies HTTP session cleanup after server shutdown. The file has no direct test-list entry shown.