Repository navigation
[None][feat] Support audio inputs in OpenEngine gRPC #20655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krishung5
wants to merge
75
commits into
NVIDIA:main
Choose a base branch
from
krishung5:openengine-audio-media
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+765
−67
Open
Changes from all commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
4973617
feat(openengine): support image inputs
krishung5 e459d67
fix(openengine): harden multimodal media handling
krishung5 7baf083
style(openengine): tighten media comments
krishung5 ab07b16
fix(openengine): harden decoded media accounting
krishung5 b44c58f
feat(openengine): support video inputs
krishung5 be67da0
feat(openengine): support audio inputs
krishung5 13e0e05
feat(openengine): support image inputs
krishung5 1748fb7
fix(openengine): harden multimodal media handling
krishung5 856630a
style(openengine): tighten media comments
krishung5 423d2b1
fix(openengine): harden decoded media accounting
krishung5 5d2e3b2
fix(media): prevent DNS rebinding during async fetches
krishung5 87f270c
feat(openengine): support image inputs
krishung5 d2cf114
fix(openengine): harden multimodal media handling
krishung5 1220a29
style(openengine): tighten media comments
krishung5 42d8a1c
fix(openengine): harden decoded media accounting
krishung5 14cb645
fix(media): prevent DNS rebinding during async fetches
krishung5 9db976c
feat(openengine): support video inputs
krishung5 a3cff30
fix(openengine): address image review feedback
krishung5 9dc3ab1
Merge remote-tracking branch 'origin/main' into openengine-image-media
krishung5 8745cae
Merge branch 'openengine-image-media' into openengine-video-media
krishung5 dac2ab5
Merge remote-tracking branch 'fork/openengine-image-media' into opene…
krishung5 7af9e07
Merge remote-tracking branch 'origin/main' into openengine-image-media
krishung5 19539c7
Merge branch 'openengine-image-media' into openengine-video-media
krishung5 b777c5c
fix(openengine): fail closed on video decoder load errors
krishung5 964bf51
Merge branch 'openengine-video-media' into openengine-audio-media
krishung5 6844e5a
feat(openengine): support audio inputs
krishung5 cfcc7b8
Merge remote-tracking branch 'origin/main' into openengine-image-media
krishung5 6253621
Merge branch 'openengine-image-media' into openengine-video-media
krishung5 e68c4af
Merge branch 'openengine-video-media' into openengine-audio-media
krishung5 1e3f7f8
fix: preserve permanent media client errors
krishung5 956cc12
Merge branch 'openengine-image-media' into openengine-video-media
krishung5 36e5552
test: fail video conformance when decoder is missing
krishung5 e19460f
Merge branch 'openengine-video-media' into openengine-audio-media
krishung5 a9b3038
test: make multimodal conformance failures explicit
krishung5 b591693
Merge remote-tracking branch 'origin/main' into openengine-video-media
krishung5 8978a9e
Merge branch 'openengine-video-media' into openengine-audio-media
krishung5 220478b
fix(openengine): reserve request IDs before media loading
krishung5 db9a687
fix(inputs): scope shared media session to event loop
krishung5 0515340
Merge branch 'openengine-image-media' into openengine-video-media
krishung5 1a27ad4
fix(openengine): reject oversized video before allocation
krishung5 7e630cc
fix(openengine): share decoded video memory budget
krishung5 4e4c9d1
Merge branch 'openengine-video-media' into openengine-audio-media
krishung5 7138d1e
test(openengine): tighten audio conformance coverage
krishung5 4941f54
fix(inputs): isolate media sessions by event loop
krishung5 36f4fb2
Merge remote-tracking branch 'origin/main' into openengine-image-media
krishung5 c0e8499
fix(openengine): validate and cancel multimodal request preparation
krishung5 88f22f8
Merge origin/main and address video decode review
krishung5 2d3a2a2
fix(openengine): budget embedded video audio before allocation
krishung5 71ed72f
Merge latest video support into audio branch
krishung5 8646ea8
fix(openengine): bound audio decoding and checkpoint capabilities
krishung5 c63d619
fix(shared-tensor): avoid global strategy races and reclaim exports
krishung5 67fb3b7
fix(openengine): own preprocessing exports and isolate media work
krishung5 bc89fc1
Merge origin/main into openengine-image-media
krishung5 487f49a
Merge image OpenEngine fixes into video stack
krishung5 2e1b47c
test(openengine): cover video preprocessing isolation after stack ref…
krishung5 53e6659
fix: resolve image OpenEngine L0 test failures
krishung5 750f17d
Merge origin/main into openengine-image-media
krishung5 af1d00b
fix: remove duplicate test request keyword after merge
krishung5 90aa910
Merge refreshed image fixes into video media branch
krishung5 1b0d941
Merge origin/main into openengine-video-media
krishung5 2d69a82
fix(openengine): stop video decoding between operations on cancellation
krishung5 b019fe6
Merge remote-tracking branch 'fork/openengine-video-media' into opene…
krishung5 674614e
Merge remote-tracking branch 'origin/main' into openengine-audio-media
krishung5 91090f5
Merge remote-tracking branch 'origin/main' into openengine-image-media
krishung5 5902c6d
Merge remote-tracking branch 'origin/main' into openengine-audio-media
krishung5 68b0ef2
[None][fix] Preserve audio contracts on the shared OpenEngine lifecycle
krishung5 53b9c63
Merge origin/main into openengine-image-media
krishung5 a51c0cf
Merge updated image support into OpenEngine video branch
krishung5 010abd4
Merge latest main into OpenEngine video support
krishung5 38ad20c
Merge origin/main after image support landed into video
krishung5 8fb1e66
Merge refreshed video stack and latest main into audio
krishung5 6a07a16
Merge remote-tracking branch 'origin/main' into openengine-audio-media
krishung5 b422f01
Merge remote-tracking branch 'origin/main' into openengine-audio-media
krishung5 adc04f7
[None][fix] Harden OpenEngine audio loading and capability discovery
krishung5 16f4d69
Merge remote-tracking branch 'origin/main' into openengine-audio-media
krishung5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not have the input processor protocol / base class declare an instance property that would declare this unambiguously? It would be a bit more future-proof since otherwise we would likely keep adding special handling for different model types.
For example (I could be wrong here), I believe nemotron v3.5 super and nemotron nano v3 omni resolve to the same model type, but the former does not support audio inputs, while the latter does.