Skip to content

Add 'void' volume-mount device in CDI spec - #2146

Merged
cdesiniotis merged 1 commit into
NVIDIA:mainfrom
cdesiniotis:add-void-volume-mount-to-cdi-spec
Oct 27, 2026
Merged

cdesiniotis merged 1 commit into
NVIDIA:mainfrom
cdesiniotis:add-void-volume-mount-to-cdi-spec

Conversation

@cdesiniotis

@cdesiniotis cdesiniotis commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Description

This is analogous to us configuring NVIDIA_VISIBLE_DEVICES=void in the CDI spec to avoid NVIDIA Container Runtime from injecting devices. When the volume-mounts strategy is enabled, e.g. when accept-nvidia-visible-devices-as-volume-mounts=true in NVIDIA Container Runtime, we should also prevent NVIDIA Container Runtime from injecting any devices specified through volume mounts.

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Unit tests passing (make test)
  • Lint checks passing (make lint)
  • Test cases are added for new code paths
  • Commits are signed-off and cryptographically signed

Testing

This is analogous to us configuring NVIDIA_VISIBLE_DEVICES=void
in the CDI spec to avoid NVIDIA Container Runtime from injecting
devices. When the volume-mounts strategy is enabled, e.g. when
accept-nvidia-visible-devices-as-volume-mounts=true in NVIDIA Container
Runtime, we should also prevent NVIDIA Container Runtime from
injecting any devices specified through volume mounts.

Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 38977749795

Coverage increased (+0.04%) to 45.155%

Details

  • Coverage increased (+0.04%) from the base build.
  • Patch coverage: 7 of 7 lines across 2 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13571
Covered Lines: 6128
Line Coverage: 45.16%
Coverage Strength: 0.45 hits per line

💛 - Coveralls

@cdesiniotis

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-1.20

@cdesiniotis
cdesiniotis merged commit 1e822e0 into NVIDIA:main Oct 27, 2026
21 checks passed
@github-actions

Copy link
Copy Markdown

🤖 Backport PR created for release-1.20: #2184 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants