Skip to content

[release-1.20] Add 'void' volume-mount device in CDI spec - #2184

Merged
cdesiniotis merged 1 commit into
release-1.20from
backport-2146-to-release-1.20
Oct 27, 2026
Merged

cdesiniotis merged 1 commit into
release-1.20from
backport-2146-to-release-1.20

Conversation

@github-actions

Copy link
Copy Markdown

🤖 Automated backport of #2146 to release-1.20

✅ Cherry-pick completed successfully with no conflicts.

Original PR: #2146
Original Author: @cdesiniotis

Cherry-picked commits (1):

  • 78f2970 Add 'void' volume-mount device in CDI spec

This backport was automatically created by the backport bot.

@copy-pr-bot

copy-pr-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot mentioned this pull request Oct 27, 2026
5 tasks done
@cdesiniotis

Copy link
Copy Markdown
Contributor

/ok to test 340007f

This is analogous to us configuring NVIDIA_VISIBLE_DEVICES=void
in the CDI spec to avoid NVIDIA Container Runtime from injecting
devices. When the volume-mounts strategy is enabled, e.g. when
accept-nvidia-visible-devices-as-volume-mounts=true in NVIDIA Container
Runtime, we should also prevent NVIDIA Container Runtime from
injecting any devices specified through volume mounts.

Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
(cherry picked from commit 78f2970)
@cdesiniotis
cdesiniotis force-pushed the backport-2146-to-release-1.20 branch from 340007f to 39198cf Compare October 27, 2026 19:25
@cdesiniotis

Copy link
Copy Markdown
Contributor

/ok to test 39198cf

@coveralls

coveralls commented Oct 27, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 40569304122

Coverage increased (+0.04%) to 44.181%

Details

  • Coverage increased (+0.04%) from the base build.
  • Patch coverage: 7 of 7 lines across 2 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13766
Covered Lines: 6082
Line Coverage: 44.18%
Coverage Strength: 0.44 hits per line

💛 - Coveralls

@cdesiniotis
cdesiniotis enabled auto-merge October 27, 2026 19:35
@cdesiniotis
cdesiniotis merged commit 29cc85a into release-1.20 Oct 27, 2026
21 checks passed
@cdesiniotis
cdesiniotis deleted the backport-2146-to-release-1.20 branch October 27, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants