Conversation
Coverage Summary
|
This was referenced Sep 13, 2026
Renders Slang's `ContractAbi` in solc's JSON-ABI spelling for every contract and library the frontend lowers, and lets `--abi` and `--hashes` through the CLI selection under the Slang frontend. `internalType` is not emitted until Slang carries it. The new `abi::matches_solc` test compares the rendered ABI to solc's, with `internalType` stripped; it failed on the previous sources with an empty output, as did `hashes::default`.
An interface and an abstract contract deploy nothing, but solc lists them with their ABI and method identifiers and no bytecode; the Slang frontend now does the same. An interface's ABI is composed from the entries Slang computes for its linearised functions, errors and events, since Slang computes no whole ABI for an interface, and the method identifiers of every object go through one `MethodIdentifiers` helper. The `SlangAbi.sol` fixture pins parity with solc over an interface, an abstract contract, a library and a contract with structs, arrays, events, errors, getters, receive and fallback.
nebasuke
force-pushed
the
slang-abi-output
branch
from
September 29, 2026 18:09
312fa1b to
1830797
Compare
This was referenced Sep 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: this PR is in a temporary state as most of this implementation will move to slang repo.
Claude summary
Emits the JSON ABI in solc's spelling for every contract, interface, abstract contract and library the Slang frontend compiles, each over its whole hierarchy, and lets
--abiand--hashesthrough the CLI. Theabi::matches_solctest pins parity with solc's ABI apart frominternalType.