Skip to content

[19.0][MIG] base_geoengine: consolidated migration - #465

Open
leNeo wants to merge 109 commits into
OCA:19.0from
leNeo:19.0-mig-base_geoengine-consolidated
Open

leNeo wants to merge 109 commits into
OCA:19.0from
leNeo:19.0-mig-base_geoengine-consolidated

Conversation

@leNeo

@leNeo leNeo commented Jun 27, 2026

Copy link
Copy Markdown

Summary

Consolidated migration of base_geoengine to 19.0. This PR brings together the
work that was scattered across several places into a single, clean-history PR:

Supersedes

This PR supersedes and should replace:

All three can be closed once this is merged.

Credits

Thanks to @weinni2000 for the migration and for handing over the consolidation,
to @juppe for the library upgrades and fixes, and to @cparadis-impressfoods for
testing. Per-commit authorship is preserved in the history.

Test plan

  • CI green (Odoo + OCB) with PostGIS
  • test_geo_search_indirect_respects_record_rules passes (new)
  • Functional check on runboat: vector/raster layers, geoengine view, edit map
  • @cparadis-impressfoods review (tested the superseded PR#7)

weinni2000 and others added 30 commits October 4, 2025 11:54
Before this change, simple geometry column were created without inforamtion regarding the geo type nor the defined SRID. Without these information, the srid has to be expliciltely set when converting data to column format.
…had to be use. Add the possibility to have a right internal domain on the right
…method with our alias to perform search method and fix tests
@leNeo

leNeo commented Aug 8, 2026

Copy link
Copy Markdown
Author

@weinni2000 @juppe @cparadis-impressfoods

This PR (#465) is a consolidated migration of base_geoengine to 19.0, including:
✅ Migration to 19.0 (originally #414)
✅ JS library upgrades (OpenLayers 10.8.0, Chroma.js 3.2.0, Geostats 2.1.0)
✅ Critical security fix: Re-applied ir.rule on indirect geo-operator sub-queries
✅ Forward-ports from 16.0 (field labels, domains)
✅ All tests pass (including new regression test for ir.rule)

Tested on:

  • CI (Odoo + OCB + PostGIS) ✅
  • Manual functional tests (vector/raster layers, geoengine view, edit map) ✅

Ready for review/merge! Could you take a look and approve if everything looks good?

Thanks!

@weinni2000 weinni2000 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leNeo

leNeo commented Aug 22, 2026

Copy link
Copy Markdown
Author

@cparadis-impressfoods @weinni2000 has approved this consolidated PR, so it needs one more review to be mergeable. Since you already tested weinni2000#7 (which is integrated here), would you mind adding your review? CI is green (Odoo + OCB + PostGIS). Thanks a lot!

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@leNeo

leNeo commented Aug 31, 2026 •

Copy link
Copy Markdown
Author

Hi @yvaucher & @yterrettaz 👋

Could you help land this one when you have a moment? Consolidated 19.0 migration of base_geoengine — CI green (Odoo + OCB + PostGIS), 2 approvals, ready to merge, no conflicts.

Since the module has no declared maintainer and you both handled the 18.0 one (#403), it just needs one of you to trigger the ocabot merge (nobump, since it's a migration).

Thanks a lot for your time, and for all the geoengine work over the years! 🙏

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @leNeo. Your command failed:

Invalid options for command merge: nobump would be perfect.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@mostafabarmshory

Copy link
Copy Markdown
Contributor

Hi @yvaucher & @yterrettaz

Is it possible to merge this with main branch, PLZ?

@leNeo leNeo mentioned this pull request Oct 3, 2026
2 of 3 tasks
@leNeo

leNeo commented Oct 3, 2026

Copy link
Copy Markdown
Author

Thanks for the review @leemannd! Since base_geoengine has no declared maintainer, a PSC member can land it — it has 2 approvals and green CI. Would you mind triggering the merge (ocabot merge nobump) when you have a moment?

@HekkiMelody

Copy link
Copy Markdown

Hello,

could you include the commits from this PR in the migration?

#476

Thanks!

@etobella

etobella commented Nov 5, 2026

Copy link
Copy Markdown
Member

@leNeo can you follow @HekkiMelody comments 🙏

@oca-cla-bot

oca-cla-bot Bot commented Nov 6, 2026

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

CLA not signed

@weinni2000

Copy link
Copy Markdown

Hi @Sanazzzmi, your commit adding RTL ignore for Persian and Arabic is included in this migration. The CLA check reports that sanazzz246@gmail.com is missing a signed Contributor License Agreement. Could you please sign at https://clabot.odoo-community.org/ and make sure this email address is covered? Thanks!

    Notifying user to define selected attribute_field_id of
supported type from vector layer as part of geoengine view
xml defintion which avoids observed JS error.

(cherry picked from commit 6985d94)
   Updated checkAttributeFieldUsage method in order to
handle a vector layer which does not contain
attribute_field_id value as the field
attribute_field_id is optional for basic representation
mode in geoengine view.

(cherry picked from commit e628a81)
@leNeo
leNeo force-pushed the 19.0-mig-base_geoengine-consolidated branch from 147fe2f to 3ee20ec Compare November 6, 2026 16:35
@leemannd

leemannd commented Nov 7, 2026

Copy link
Copy Markdown

Hello @leNeo I have created a PR for improvements leNeo#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.