Repository navigation
Conversation
…d create multipolygon
…es and add a menu
…view in geo_edit_map
Before this change, simple geometry column were created without inforamtion regarding the geo type nor the defined SRID. Without these information, the srid has to be expliciltely set when converting data to column format.
…had to be use. Add the possibility to have a right internal domain on the right
…method with our alias to perform search method and fix tests
|
@weinni2000 @juppe @cparadis-impressfoods This PR (#465) is a consolidated migration of Tested on:
Ready for review/merge! Could you take a look and approve if everything looks good? Thanks! |
|
@cparadis-impressfoods @weinni2000 has approved this consolidated PR, so it needs one more review to be mergeable. Since you already tested weinni2000#7 (which is integrated here), would you mind adding your review? CI is green (Odoo + OCB + PostGIS). Thanks a lot! |
|
This PR has the |
|
Hi @yvaucher & @yterrettaz 👋 Could you help land this one when you have a moment? Consolidated 19.0 migration of base_geoengine — CI green (Odoo + OCB + PostGIS), 2 approvals, ready to merge, no conflicts. Since the module has no declared maintainer and you both handled the 18.0 one (#403), it just needs one of you to trigger the ocabot merge (nobump, since it's a migration). Thanks a lot for your time, and for all the geoengine work over the years! 🙏 |
|
Hi @leNeo. Your command failed:
Ocabot commands
More information
|
|
Hi @yvaucher & @yterrettaz Is it possible to merge this with main branch, PLZ? |
|
Thanks for the review @leemannd! Since |
|
Hello, could you include the commits from this PR in the migration? Thanks! |
|
@leNeo can you follow @HekkiMelody comments 🙏 |
|
The following commit authors need to sign the Contributor License Agreement: |
|
Hi @Sanazzzmi, your commit adding RTL ignore for Persian and Arabic is included in this migration. The CLA check reports that sanazzz246@gmail.com is missing a signed Contributor License Agreement. Could you please sign at https://clabot.odoo-community.org/ and make sure this email address is covered? Thanks! |
Notifying user to define selected attribute_field_id of supported type from vector layer as part of geoengine view xml defintion which avoids observed JS error. (cherry picked from commit 6985d94)
Updated checkAttributeFieldUsage method in order to handle a vector layer which does not contain attribute_field_id value as the field attribute_field_id is optional for basic representation mode in geoengine view. (cherry picked from commit e628a81)
147fe2f to
3ee20ec
Compare
Summary
Consolidated migration of
base_geoengineto 19.0. This PR brings together thework that was scattered across several places into a single, clean-history PR:
dynamic lib loading and a WKT/WKB detection fix — by @juppe
(Fixes to 19.0 migration and JS libraries update weinni2000/geospatial#7).
Params WMS,attribute_field_iddomain) — originally [18.0][FW] base_geoengine: multiple ports from 16.0 #431.
ir.rule) on the indirect geo-operatorsub-queries. The migration had replaced
_apply_ir_rules(removed in 19.0)by
_check_field_access, which no longer applied row-level security to thespatial sub-query — a restricted user could match related records they are not
allowed to read. Re-applied in
where_calc, mirroringBaseModel._search,with a regression test (non-admin user +
ir.rule).Supersedes
This PR supersedes and should replace:
All three can be closed once this is merged.
Credits
Thanks to @weinni2000 for the migration and for handing over the consolidation,
to @juppe for the library upgrades and fixes, and to @cparadis-impressfoods for
testing. Per-commit authorship is preserved in the history.
Test plan
test_geo_search_indirect_respects_record_rulespasses (new)