Skip to content

[IMP] hr_payroll_document: Simplify email layout - #323

Open
SirPyTech wants to merge 2 commits into
OCA:16.0from
PyTech-SRL:16.0-imp-hr_payroll_document-mail_template
Open

SirPyTech wants to merge 2 commits into
OCA:16.0from
PyTech-SRL:16.0-imp-hr_payroll_document-mail_template

Conversation

@SirPyTech

Copy link
Copy Markdown

Remove all the style and html tags from the email sent to the employee to start with a very simple text, and allow the user to customize it (noupdate).

Here I also changed the email's related model to ir.attachment.payroll.custom because that is the link between the employee, the subject and the payslip (attachment).
Rendering the email based on such model, it is possible to use the existing standard email layout for the generated email mail.mail_notification_light.
Before these changes:

  • employee chatter: image
  • employee email: image

After these changes:

  • employee chatter: image
  • employee email: image

I also included a small [FIX]: the payslip was being attached to the email template too, after that commit, it does not happen anymore.

The email layout is delegated to existing dedicated QWeb templates.
Allow the user to edit the template (noupdate).
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @peluko00,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added series:16.0 mod:hr_payroll_document Module hr_payroll_document labels Nov 2, 2026

@HekkiMelody HekkiMelody left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

HekkiMelody

This comment was marked as duplicate.

@PicchiSeba PicchiSeba left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: LGTM

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@anusriNPS anusriNPS left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and Functional Review: LGTM
Minor typo in email template could be corrected. Same could be taken care in FW PRs #334 and #333.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants