Skip to content

[IMP] hr_payroll_document: Simplify email layout - #333

Open
SirPyTech wants to merge 2 commits into
OCA:18.0from
PyTech-SRL:18.0-imp-hr_payroll_document-mail_template
Open

SirPyTech wants to merge 2 commits into
OCA:18.0from
PyTech-SRL:18.0-imp-hr_payroll_document-mail_template

Conversation

@SirPyTech

Copy link
Copy Markdown

Forward porting to 18.0 the same changes proposed in #323.

Remove all the style and html tags from the email sent to the employee to start with a very simple text, and allow the user to customize it (noupdate).
[...]
I also included a small [FIX]: the payslip was being attached to the email template too, after that commit, it does not happen anymore.

The email layout is delegated to existing dedicated QWeb templates.
Allow the user to edit the template (noupdate).

(cherry picked from commit 7f2e7df)

@HekkiMelody HekkiMelody left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@anusriNPS anusriNPS left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and Functional Review: LGTM

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants