Repository navigation
Fix CUDA profiling builds with NVTX3 - #479
Merged
Merged
Conversation
shakedregev
approved these changes
Oct 6, 2026
shakedregev
left a comment
Collaborator
There was a problem hiding this comment.
Looks good and tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix CUDA profiling builds with recent CUDA toolkits that no longer provide the legacy
CUDA::nvToolsExtlibrary target.With CUDA 12.9, enabling
RESOLVE_USE_PROFILINGcaused CMake generation to fail becauselibnvToolsExtis no longer shipped. NVTX3 is its supported header-only replacement.No additional dependencies are required.
Proposed changes
CUDA::nvtx3target when available.<nvtx3/nvToolsExt.h>for NVTX3 builds.RESOLVE_USE_NVTX3to downstream consumers.CUDA::nvToolsExtas a fallback for older CUDA/CMake environments.The change was built using CUDA 12.9.1 for SM90 and tested on an NVIDIA H100.
Checklist
make testandmake test_installper testing instructions). Code tested on./examples/<your_example>.exe -hto get instructions how to run examples). Code tested on:-Wall -Wpedantic -Wconversion -Wextra.Further comments
The following smoke tests passed:
The installed CMake package was also checked and correctly exports
CUDA::nvtx3andRESOLVE_USE_NVTX3.