Skip to content

Fix CUDA profiling builds with NVTX3 #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shakedregev merged 1 commit into from
Oct 6, 2026
Merged

Fix CUDA profiling builds with NVTX3 #479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmake/ReSolveFindCudaLibraries.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@ if(RESOLVE_USE_CUDSS)
endif()

if(RESOLVE_USE_PROFILING)
target_link_libraries(resolve_cuda INTERFACE CUDA::nvToolsExt)
if(TARGET CUDA::nvtx3)
target_link_libraries(resolve_cuda INTERFACE CUDA::nvtx3)
target_compile_definitions(resolve_cuda INTERFACE RESOLVE_USE_NVTX3)
else()
target_link_libraries(resolve_cuda INTERFACE CUDA::nvToolsExt)
endif()
endif()

install(TARGETS resolve_cuda EXPORT ReSolveTargets)
4 changes: 4 additions & 0 deletions resolve/Profiling.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@
#endif // RESOLVE_USE_HIP

#ifdef RESOLVE_USE_CUDA
#ifdef RESOLVE_USE_NVTX3
#include <nvtx3/nvToolsExt.h>
#else
#include <nvToolsExt.h>
#endif // RESOLVE_USE_NVTX3
#define RESOLVE_RANGE_PUSH(x) nvtxRangePush(x)
#define RESOLVE_RANGE_POP(x) \
nvtxRangePop(); \
Expand Down
Loading