Repository navigation
Rast_log_colors: Another attempt to address r.colors -g/-a (#1480) - #1937
Merged
Merged
Conversation
HuidaeCho
changed the title
HuidaeCho
marked this pull request as draft
October 11, 2021 05:03
HuidaeCho
marked this pull request as ready for review
October 11, 2021 05:53
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
… (OSGeo#1937) * color_xform: Another attempt to address r.colors -g/-a (OSGeo#1480) * Fix absolute log * Add a comment
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
… (OSGeo#1937) * color_xform: Another attempt to address r.colors -g/-a (OSGeo#1480) * Fix absolute log * Add a comment
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike #1481 or #1923, two other PRs trying to address #1480, this PR shifts cell values by a delta if the min is less than or equal to 0 such that the logs of shifted min and max can be calculated. Then, just before writing color rules, unshifted cell values are approximated by subtracting the delta.