Skip to content

docs: replace outdated WMS server in r.out.vtk example - #4897

Merged
petrasovaa merged 3 commits into
OSGeo:mainfrom
rohannallamadge:Mercator
May 28, 2026
Merged

petrasovaa merged 3 commits into
OSGeo:mainfrom
rohannallamadge:Mercator

Conversation

@rohannallamadge

Copy link
Copy Markdown
Contributor

Replaced the dead WMS server with https://gibs.earthdata.nasa.gov/wms/epsg3857/best/wms.cgi.

Updated the layer used in the example to BlueMarble_ShadedRelief_Bathymetry.

Adjusted the region settings using g.region to ensure proper visualization.

Updated commands for fetching RGB data (r.in.wms) and exporting it to VTK format (r.out.vtk).

@github-actions github-actions Bot added raster Related to raster data processing HTML Related code is in HTML module docs labels Dec 29, 2024
@rohannallamadge rohannallamadge changed the title fix: replace outdated WMS server in r.out.vtk example #48444 fix: replace outdated WMS server in r.out.vtk example #4844 Dec 29, 2024
@petrasovaa petrasovaa linked an issue Dec 30, 2024 that may be closed by this pull request
@echoix echoix changed the title fix: replace outdated WMS server in r.out.vtk example #4844 docs: replace outdated WMS server in r.out.vtk example Dec 31, 2024
@pesekon2

pesekon2 commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

Please update also the title of the example. Currently, it says Spearfish example with RGB data. However, that's not what the example is about and the Spearfish location is in a different projection making your example not working due to reprojection. If you wish, you could use even your own projection in the example if you specify it so the user knows how to reproduce the example.

@echoix

echoix commented Feb 26, 2025

Copy link
Copy Markdown
Member

When this PR would be worked on again, remember to make the change in the markdown file instead/additionnally.

@pesekon2

Copy link
Copy Markdown
Contributor

@rohannallamadge: Do you plan to fix the last things I noted? The PR needs just final touches and would be ready to be merged.

@gkneighb gkneighb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two items from the earlier feedback are still outstanding before this can land:

  1. The "Spearfish example with RGB data" section heading is now misleading — the region you switched to (n=7000000 s=5000000) covers most of the northern hemisphere rather than the Spearfish location, per @pesekon2's Jan 7 comment. Renaming the heading to something like "Global RGB overlay example" would resolve the inconsistency.

  2. raster/r.out.vtk/r.out.vtk.md carries an identical Spearfish/JPL block that needs the same swap, per @echoix's Feb 26 comment (AGENTS.md requires .md and .html to stay in sync).

If you're tight on time, happy to open a small follow-up PR with both fixes once this merges; otherwise they'd take just a few minutes to push here. This PR is one tiny round away from done.

@petrasovaa petrasovaa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example needed some actual testing...

@petrasovaa
petrasovaa enabled auto-merge (squash) May 28, 2026 03:10
@github-actions github-actions Bot added the markdown Related to markdown, markdown files label May 28, 2026
@petrasovaa
petrasovaa merged commit 4fd587d into OSGeo:main May 28, 2026
22 checks passed
@github-actions github-actions Bot added this to the 8.6.0 milestone May 28, 2026
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Jul 7, 2026
Use nc dataset

---------

Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs HTML Related code is in HTML markdown Related to markdown, markdown files module raster Related to raster data processing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Replace wms server in r.out.vtk example

5 participants