Repository navigation
docs: replace outdated WMS server in r.out.vtk example - #4897
Conversation
rohannallamadge
commented
Dec 29, 2024
|
Please update also the title of the example. Currently, it says Spearfish example with RGB data. However, that's not what the example is about and the Spearfish location is in a different projection making your example not working due to reprojection. If you wish, you could use even your own projection in the example if you specify it so the user knows how to reproduce the example. |
|
When this PR would be worked on again, remember to make the change in the markdown file instead/additionnally. |
|
@rohannallamadge: Do you plan to fix the last things I noted? The PR needs just final touches and would be ready to be merged. |
gkneighb
left a comment
There was a problem hiding this comment.
Two items from the earlier feedback are still outstanding before this can land:
-
The "Spearfish example with RGB data" section heading is now misleading — the region you switched to (
n=7000000 s=5000000) covers most of the northern hemisphere rather than the Spearfish location, per @pesekon2's Jan 7 comment. Renaming the heading to something like "Global RGB overlay example" would resolve the inconsistency. -
raster/r.out.vtk/r.out.vtk.mdcarries an identical Spearfish/JPL block that needs the same swap, per @echoix's Feb 26 comment (AGENTS.mdrequires.mdand.htmlto stay in sync).
If you're tight on time, happy to open a small follow-up PR with both fixes once this merges; otherwise they'd take just a few minutes to push here. This PR is one tiny round away from done.
petrasovaa
left a comment
There was a problem hiding this comment.
The example needed some actual testing...
Use nc dataset --------- Co-authored-by: Anna Petrasova <kratochanna@gmail.com>