Repository navigation
v.patch: increase the buffer for column names - #7351
Merged
Merged
Conversation
metzm
added
bug
echoix
reviewed
Apr 29, 2026
nilason
requested changes
Apr 29, 2026
Contributor
|
As a parenthesis, both snprintf and G_strlcat (and similar functions) truncates the resulting string if the attempted string do not fit the buffer, so there will be no overflow (but obviously other issues). |
Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
nilason
reviewed
Apr 30, 2026
nilason
approved these changes
Apr 30, 2026
metzm
added a commit
that referenced
this pull request
Apr 30, 2026
* larger buffer for column names * simplify code * fix comparison of integers of different signedness --------- Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
metzm
added a commit
that referenced
this pull request
Apr 30, 2026
* larger buffer for column names * simplify code * fix comparison of integers of different signedness --------- Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
wenzeslaus
removed
backport to 8.4
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Jul 7, 2026
* larger buffer for column names * simplify code * fix comparison of integers of different signedness --------- Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
v.patch -efails with an overflow error if the input tables contain many columns whose names are concatenated longer than 4096 characters. This PR increases the limit to DB_SQL_MAX = 65536 and adds tests to avoid buffer overflow.