Repository navigation
CI: Updated include path for OSGeo4W cairo 1.18 - #7507
Merged
Merged
Conversation
1 task done
Contributor
Author
|
Whoops need to update |
Member
|
Contributor
Author
Yes. |
echoix
approved these changes
Jun 6, 2026
Member
|
A backport is probably needed. And maybe needs to be rereleased unless osgeo4w adds a patch for 8.5. But 8.5 is not released yet on osgeo4w yet. Only the 8.6dev and 8.4.x one |
Member
|
Backport should be done, so builds can continue to be made in CI |
jef-n
added a commit
to jef-n/OSGeo4W
that referenced
this pull request
Jun 12, 2026
Member
|
@neteler can we have this backported to all where we can? No ci can run through the configure step without this. |
neteler
pushed a commit
that referenced
this pull request
Jun 14, 2026
Fixed Windows OSGeo4W build by updating `--with-cairo-includes=${OSGEO4W_ROOT_MSYS}/include` to `--with-cairo-includes=${OSGEO4W_ROOT_MSYS}/include/cairo`.
The change is from OSGeo4W migrating its cairo package to Meson and bumped it to 1.18.4 (jef-n/OSGeo4W@c3b8830).
* mswindows: Updated include path for OSGeo4W cairo 1.18
* Updated include path for OSGeo4W cairo 1.18
neteler
added a commit
that referenced
this pull request
Jun 14, 2026
Member
Member
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Jul 7, 2026
Fixed Windows OSGeo4W build by updating `--with-cairo-includes=${OSGEO4W_ROOT_MSYS}/include` to `--with-cairo-includes=${OSGEO4W_ROOT_MSYS}/include/cairo`.
The change is from OSGeo4W migrating its cairo package to Meson and bumped it to 1.18.4 (jef-n/OSGeo4W@c3b8830).
* mswindows: Updated include path for OSGeo4W cairo 1.18
* Updated include path for OSGeo4W cairo 1.18
petrasovaa
added a commit
to petrasovaa/grass-addons
that referenced
this pull request
Nov 3, 2026
OSGeo4W moved the cairo headers to include/cairo after 8.5.0 was released; main has the fix from OSGeo/grass#7507. Apply the same one-line change the OSGeo4W grass package recipe applies to the 8.5.0 sources before compiling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Windows OSGeo4W build by updating
--with-cairo-includes=${OSGEO4W_ROOT_MSYS}/includeto--with-cairo-includes=${OSGEO4W_ROOT_MSYS}/include/cairo.The change is from OSGeo4W migrating its cairo package to Meson and bumped it to 1.18.4 (jef-n/OSGeo4W@c3b8830).