Skip to content

t.connect: Add formats - #7535

Merged
petrasovaa merged 4 commits into
OSGeo:mainfrom
saket0187:Add-formats-t.connect
Jun 18, 2026
Merged

petrasovaa merged 4 commits into
OSGeo:mainfrom
saket0187:Add-formats-t.connect

Conversation

@saket0187

Copy link
Copy Markdown
Contributor

This PR adds feature requested in #7504

The test file I added contains very small tests. Should we keep it?

@github-actions github-actions Bot added temporal Related to temporal data processing Python Related code is in Python C Related code is in C module docs markdown Related to markdown, markdown files tests Related to Test Suite CMake labels Jun 11, 2026
@petrasovaa

Copy link
Copy Markdown
Contributor

The test file I added contains very small tests. Should we keep it?

Create a pytest in a separate PR.

Comment thread temporal/t.connect/main.c Resolved
@saket0187

Copy link
Copy Markdown
Contributor Author

The test file I added contains very small tests. Should we keep it?

Create a pytest in a separate PR.

I'm happy to move the tests to a separate PR! Just to double-check: since these tests specifically validate the new C logic added here, wouldn't it make more sense to just convert this file to pytest in this PR only, or should I strictly keep the C code and tests separated?

@petrasovaa @ninsbl

@petrasovaa

Copy link
Copy Markdown
Contributor

The test file I added contains very small tests. Should we keep it?

Create a pytest in a separate PR.

I'm happy to move the tests to a separate PR! Just to double-check: since these tests specifically validate the new C logic added here, wouldn't it make more sense to just convert this file to pytest in this PR only, or should I strictly keep the C code and tests separated?

@petrasovaa @ninsbl

Sorry what I meant to say is to create a pytest testing the current functionality in a separate PR and (after that is merged) then in this PR expand on that test - that way we can check there is no regression.

@saket0187 saket0187 mentioned this pull request Jun 15, 2026
@saket0187
saket0187 requested a review from petrasovaa June 16, 2026 12:45
@saket0187

Copy link
Copy Markdown
Contributor Author

Hello @ninsbl , I believe I have addressed issue #7538 as well. It seems the exit() statement was simply missing. Could you please take a look and cross-check it on your end?

Comment thread temporal/t.connect/t.connect.md Resolved
Co-authored-by: Stefan Blumentrath <stefan.blumentrath@gmx.de>
@petrasovaa
petrasovaa merged commit 96cf98d into OSGeo:main Jun 18, 2026
26 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in GRASS Google Summer of Code 2026 Jun 18, 2026
@github-actions github-actions Bot added this to the 8.6.0 milestone Jun 18, 2026
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Jul 7, 2026
Fixes behavior when -g flag is used without -p
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Related code is in C CMake docs markdown Related to markdown, markdown files module Python Related code is in Python temporal Related to temporal data processing tests Related to Test Suite

Development

Successfully merging this pull request may close these issues.

3 participants