Skip to content

temporal: deliberately set nprocs for functions that use OpenMP-parallelized tools - #7913

Merged
ninsbl merged 3 commits into
OSGeo:mainfrom
ninsbl:t_univar_nprocs
Sep 12, 2026
Merged

ninsbl merged 3 commits into
OSGeo:mainfrom
ninsbl:t_univar_nprocs

Conversation

@ninsbl

@ninsbl ninsbl commented Sep 11, 2026

Copy link
Copy Markdown
Member

After parallelization of several tools, with OpenMP, some temporal functions can overcommit ressources to parallel execution of such tools. Similar issues have been fixed for r.mapcalc. This PR applies the approach for r.mapcalc to r.univar and r.series.

  • set nprocs=1 for functions that execute OpenMP-parallelized tools in parallel
  • use 0 (=all available cores) as a default, when parallelized tools are called serial (e.g. in a single for-loop)

@ninsbl ninsbl added this to the 8.6.0 milestone Sep 11, 2026
@ninsbl ninsbl added the bug Something isn't working label Sep 11, 2026
@github-actions github-actions Bot added Python Related code is in Python libraries labels Sep 11, 2026
@echoix

echoix commented Sep 11, 2026

Copy link
Copy Markdown
Member

Good idea, but multiple test issues to address first..

@ninsbl

ninsbl commented Sep 12, 2026

Copy link
Copy Markdown
Member Author

Good idea, but multiple test issues to address first..

Right, I think the problem was that r3.univar does not have a nprocs option. Hopefully fixed in ca59d35

@ninsbl
ninsbl requested a review from echoix September 12, 2026 17:43
@ninsbl
ninsbl enabled auto-merge (squash) September 12, 2026 17:44

@echoix echoix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ninsbl
ninsbl merged commit 0b4a960 into OSGeo:main Sep 12, 2026
26 checks passed
@ninsbl
ninsbl deleted the t_univar_nprocs branch September 12, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working libraries Python Related code is in Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants