Repository navigation
i18n: Use complete source strings instead of fragments (Python) - #8011
Conversation
The verbose and fatal messages were assembled from fragments such as ' larger than or equal to %f hectares...', which translators cannot reorder. Use one complete string for each combination of thresholds.
The reason was appended to a translated string ending in 'Reason: '.
Cover the render status bar, scatterplot title and axis labels, RLi sample area title (previously a runtime string passed to gettext, so never translated), database table tab labels, GCP overwrite question, and two incomplete or trailing-space messages.
Replace messages assembled from translated fragments or passed to gettext as already-built strings with complete format strings, in the temporal framework, wxGUI toolbars, selectors and logs, and several scripts. Also drop trailing spaces from a few messages. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ds column message
f25496f to
9705e3b
Compare
…eConnection Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
Applying the review suggestions for the mogrify and transaction mapset errors kept the old fatal() calls unclosed before the new ones, which made core.py fail to compile.
be2276f to
d265a24
Compare
76a09d2 to
f16b010
Compare
|
Sorry for the noise. On a fresh mind, I relooked at the PR. I fine tuned some little extra messages that weren't in the initial PR, but that had similar messages than the ones that were changed in this PR, such as all of the similar messages are fixed in the same way. Ai reviewed the different branches of r.reclass.area, where now the message isn't built by parts. See the table in the full output of the last review I made it do, even if it's worded for me, the table is still fine and cross-verifies the work: Details
CI is still running on the new head. I'm checking the I updated my local copy to your new head, What changed since my last review is only in
I didn't build GRASS, so I didn't run the tool or its Nits (all optional):
I haven't posted any of this to the PR. |
|
@ninsbl can you take a look here? Just to validate that I didn't miss something big (and AI either), I think it's fine |
This is a first start of fixing issues that I noted in comments in Weblate, for python files.
Description
Some messages were built from separately translated fragments, or from a runtime string passed to gettext, so translators cannot adapt word order or punctuation. These were flagged by comments on Weblate. This PR replaces them with complete format strings in the Python tools and the wxGUI; the C code is in a separate PR.
r.reclass.area: complete messages, one per combination of thresholds.r.in.wms,v.what.strds,v.rast.stats,r.in.srtm,m.proj: error and status messages are single strings (no trailing-space fragments).core.py,temporal_algebra.py): the mapset error and the wrong-input error were built before being passed to gettext, so they were never translated._("Select sample area 1 of " + str(n)); it now uses the same msgid as the update just above it.tplot: the CSV error message ended in "or " with nothing after it. It now reads "Please change name of output CSV file or enable overwriting." Please check the wording matches the intent.Motivation and context
Translators on Weblate reported that these messages cannot be translated correctly with a different word order.
How has this been tested?
ruff formatandruff checkreport no changes; the modified files compile.Types of changes
functionality to not work as before)
Checklist
pre-defined prefixes
of this project.
AI assistance (Claude) was used to find the affected strings and to draft these changes.