chore: Marketplace hygiene — MFTF checkout race, zip contents, coding standard - #82
Merged
Merged
Conversation
Constructor and helper docblocks, and a log call wrapped under 120 columns. No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It is a leftover Docker template from the original dev setup, not package content. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…pping estimate Filling the address re-estimates shipping behind a loading mask and re-renders the method list, so the raw radio click was intercepted by the mask (or hit a stale element). Wait for the mask and use the core CheckoutSelectFlatRateShippingMethod / StorefrontCheckoutClickNextButton action groups. Failed 2/2 before on dev-repro, passed 5/5 after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission cleanups found while checking the #69 fix (#81) against what Adobe's Marketplace review runs.
Changes
StorefrontPaystackCheckoutRendersTestraced the shipping estimate. Filling the address re-estimates shipping behind a loading mask and re-renders the method list, so the raw radio click was intercepted by the mask (or hit a stale element). Now waits for the mask and uses the coreCheckoutSelectFlatRateShippingMethodActionGroup/StorefrontCheckoutClickNextButtonActionGroup. Adobe runs vendor MFTF tests; a previous submission already failed on one of ours..env.sample(a leftover Docker template) is excluded from the Marketplace zip — 88 files now, all package content. CLAUDE.md's exclusion list updated.Model/WebhookOrderResolver.phpnow has 0 errors / 0 warnings undermagento/magento-coding-standard(docblocks, one wrapped log call). No behaviour change.Verification
StorefrontPaystackCheckoutRendersTestfailed 2/2 as written at the shipping-method click, passed 5/5 after the change;PaystackPaymentConfigAvailableTestpasses.magento/magento-coding-standardover the module: 0 errors.Not covered: Adobe Commerce (EE) — the EE harness needs working Adobe keys.
🤖 Generated with Claude Code