feat(runtime): distinguish a configured egress policy from an unset one - #1142
Merged
trunk-io[bot] merged 1 commit intoSep 13, 2026
Conversation
This was referenced Sep 12, 2026
Merged
rigel-mintaka
added this pull request to stack #1126
September 12, 2026 04:10
|
Compass engineering docs preview: https://compass-service-owner-rig-35-elxl.compass-eng-docs.pages.dev Deployed from |
This was referenced Sep 12, 2026
mattwilkinsonn
approved these changes
Sep 12, 2026
An empty allowlist is the strictest posture — pure default-deny — while a zero-value policy means egress was never configured. The two were indistinguishable, so a tier that cannot enforce egress had no way to refuse a policy without also rejecting the tightest one. AllowEgress now marks the policy configured, and Configured() exposes it. Hosts() and NftScript() are untouched, so container arming is unchanged.
rigel-mintaka
force-pushed
the
compass-service-owner/rig-3512-egress-configured
branch
from
September 12, 2026 19:37
13a2767 to
ab53b80
Compare
mattwilkinsonn
approved these changes
Sep 12, 2026
trunk-io
Bot
deleted the
compass-service-owner/rig-3512-egress-configured
branch
September 13, 2026 00:29
|
This pull request was merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 10 PRs:
mainAn empty allowlist is the strictest posture — pure default-deny — while a
zero-value policy means egress was never configured. The two were
indistinguishable, so a tier that cannot enforce egress had no way to refuse a
policy without also rejecting the tightest one.
AllowEgress now marks the policy configured, and Configured() exposes it.
Hosts() and NftScript() are untouched, so container arming is unchanged.