Honor $(STRIP) in install-strip for cross-compilation#1024
Open
alessandrodn wants to merge 1 commit into
Open
Conversation
The install-strip target hard-coded `install -s`, which strips via the install program using the build host's strip and ignores the STRIP variable. When cross-compiling this runs the host strip against a target binary and fails. Pass --strip-program=$(or $(STRIP),strip) so the target strip is used when STRIP is set (as cross toolchains and build systems provide), falling back to plain `strip` for native builds. A plain `make install` is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
install-striptarget hard-codedinstall -s, which strips via the install program using the build host's strip and ignores theSTRIPvariable, and rsync's configure.ac has no AC_CHECK_TOOL([STRIP], …) to detect a cross strip.When cross-compiling,
make install-striptherefore runs the hoststripagainst a target-architecture binary and fails.This changes
install-stripto pass--strip-program=$(or $(STRIP),strip), so the target strip is used whenSTRIPis set (as cross toolchains and build systems like Conan/Buildroot/Yocto provide), while falling back to plain strip for native builds. A plain make install is unaffected.