Skip to content

Honor $(STRIP) in install-strip for cross-compilation #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alessandrodn wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Honor $(STRIP) in install-strip for cross-compilation #1024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ install-ssl-daemon: stunnel-rsyncd.conf
install-all: install install-ssl-daemon

install-strip:
$(MAKE) INSTALL_STRIP='-s' install
$(MAKE) INSTALL_STRIP='-s --strip-program=$(or $(STRIP),strip)' install

@steadytao steadytao Jul 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumes GNU Make through $(or ...) and GNU install through --strip-program while AC_PROG_INSTALL may select the bundled install-sh. Please detect/substitute the target STRIP and implement this portably, for example by installing normally then invoking $(STRIP) on the installed rsync binary.

This also needs native and cross-strip tests which I am happy to contribute if wanted.


.PHONY: uninstall
uninstall:
Expand Down