Fix/sliding sync avatars packs#1112
Merged
Merged
Conversation
eleboucher
force-pushed
the
fix/sliding-sync-avatars-packs
branch
from
July 18, 2026 08:46
60feb97 to
b8b9dd8
Compare
eleboucher
marked this pull request as ready for review
July 18, 2026 08:46
7w1
approved these changes
Jul 18, 2026
11 tasks
mortebrume
pushed a commit
to eleboucher/Sable
that referenced
this pull request
Jul 18, 2026
…Client#1119) <!-- Please read https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before submitting your pull request --> ### Description Fixes a regression in SableClient#1112 where every subspace of a space with an emoji pack was shown separately in the server list with sliding sync. We now wait until the room list is loaded before fetching an emoji pack. #### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings ### AI disclosure: - [ ] Partially AI assisted (clarify which code was AI assisted and briefly explain what it does). - [ ] Fully AI generated (explain what all the generated code does in moderate detail). <!-- Write any explanation required here, but do not generate the explanation using AI!! You must prove you understand what the code in this PR does. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes three sliding sync regressions:
useRoomAvatarhook./profilefallback and theirm.room.memberevent isn't in the lazy sync window. The timeline now hydrates missing members on demand, with a 5 min negative cache for failed fetches.space_image_packscomposite key, and pack rooms are subscribed at client load instead of on first emoji board open.Fixes #
Type of change
Checklist:
AI disclosure: