Skip to content

Fix/sliding sync avatars packs#1112

Merged
7w1 merged 4 commits into
SableClient:devfrom
eleboucher:fix/sliding-sync-avatars-packs
Jul 18, 2026
Merged

Fix/sliding sync avatars packs#1112
7w1 merged 4 commits into
SableClient:devfrom
eleboucher:fix/sliding-sync-avatars-packs

Conversation

@eleboucher

@eleboucher eleboucher commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes three sliding sync regressions:

  • Space icons stayed blank on first load: avatar state arrives after the sidebar renders and nothing re-rendered on it. Space tabs now use the reactive useRoomAvatar hook.
  • Bridged users had no timeline avatars: ghosts have no /profile fallback and their m.room.member event isn't in the lazy sync window. The timeline now hydrates missing members on demand, with a 5 min negative cache for failed fetches.
  • Packs hosted on space rooms didn't load: the space subscription key won over the image-pack one and doesn't request pack state. Added a space_image_packs composite key, and pack rooms are subscribed at client load instead of on first emoji board open.

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@eleboucher
eleboucher force-pushed the fix/sliding-sync-avatars-packs branch from 60feb97 to b8b9dd8 Compare July 18, 2026 08:46
@eleboucher
eleboucher marked this pull request as ready for review July 18, 2026 08:46
@eleboucher
eleboucher requested review from 7w1 and hazre as code owners July 18, 2026 08:46
@7w1
7w1 added this pull request to the merge queue Jul 18, 2026
Merged via the queue into SableClient:dev with commit 0d5613a Jul 18, 2026
12 checks passed
mortebrume pushed a commit to eleboucher/Sable that referenced this pull request Jul 18, 2026
…Client#1119)

<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

Fixes a regression in SableClient#1112 where every subspace of a space with an
emoji pack was shown separately in the server list with sliding sync. We
now wait until the room list is loaded before fetching an emoji pack.

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants