Repository navigation
docs: add advisor plugin category RFC (Draft) - #20
Conversation
Proposes a second plugin category alongside the existing instrument plugins, so that System One style decision models can be plugged in without putting vendor specifics into Core: - introduce category = instrument | advisor, with its own entry point group (wavebench.advisor) and API version gate, instead of extending PluginKind - keep the data-egress consent gate and the wavebench.decision.v1 artifact contract in Core, so every advisor gets the same preview/consent/audit surface - ship a deterministic builtin rule_advisor so the category is testable offline and the "beat the deterministic baseline" comparison is executable - record the six proposed decisions and the acceptance gates Status is Draft. This commit changes documentation only; no Core behaviour.
Brings the WaveBench x Jev draft track (seam v2, Core stage-1 skeleton, findings and planning files) under docs/project/design/advisor-draft so the work is reviewable in-repo; the RFC itself already arrives with the PR Scaxlibur#20 commit.
Brings the WaveBench x Jev draft track (seam v2, Core stage-1 skeleton, findings and planning files) under docs/project/design/advisor-draft so the work is reviewable in-repo; the RFC itself already arrives with the PR Scaxlibur#20 commit.
|
建议继续保持 RFC 为
另建议先选定一个具体的 WaveBench 判断任务,提供输入、期望答案及规则基线的比较标准,再决定首版需要哪些 capability。 已核对当前实现与完整差异;两页定点严格文档检查为 0 错误、0 警告,当前 5 项 CI 全部通过。上述意见主要涉及契约完整性,现有检查尚不能验证这些设计约束。 |
|
已在
首版任务收窄为已有采集报告的人工复核建议( 验证:改动页及直接 RFC 导航的严格文档检查 0 错误 / 0 警告;生成 Reference 检查、严格 MkDocs 构建、diff whitespace 检查通过。示例命令明确为提案语法;未实现 advisor 运行时,未连接仪器。 |
This Draft RFC proposes an advisor category alongside the current V2 executable instrument plugins. The existing InstrumentDescriptor/factory/registry contract requires instrument models and capabilities; an advisor needs an independent invocation and validation contract. V1 metadata remains deprecated compatibility behavior.
The proposal defines a descriptor/factory with offline prepare and authorized execute stages, request and answer validation, and a first capture-triage task with a deterministic rule baseline. Core binds per-call consent to the complete prepared request, constrains run-scoped consent with an explicit template and limits, and records standalone calls and failures as well as successful run-associated calls. Probability, provider confidence, and per-question display thresholds have separate meanings; advisor output never controls an experiment or changes safety/quality gates.
This PR changes documentation only. Advisor APIs, commands, configuration, and artifacts remain proposed; the RFC remains Draft. V1 deprecation is also marked in the plugin Concept and Reference without removing runtime compatibility.
Validation: scoped strict documentation audit (0 errors, 0 warnings), generated Reference drift check, strict MkDocs build, and git diff whitespace check. Checks ran offline with respect to instruments; no instrument configuration or experiment data was changed.