Repository navigation
Add basics-speed module with /speed command - #160
Merged
mfnalex merged 2 commits intoOct 14, 2026
Merged
Conversation
Member
|
Why is the argument an integer instead of a float? If 1 is vanilla, then 0.5 or 1.5 etc should be possible. |
Author
|
Good point, there was no reason for it to be an integer. Changed in 4b26352: |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EE9ZFuiZvhoWuGuZx6MPxV
JanTuck
force-pushed
the
claude/generate-essentials-prs-m7lzoq
branch
from
October 14, 2026 15:03
4b26352 to
b4e0938
Compare
Author
|
Follow-up: instead of a module-local argument, the float parsing now lives in core as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
basics-speedmodule, an EssentialsX-style feature built on the existing Basics core: the parsed command DSL and core arguments (IntRangeArg,StringOptionArg,SelectorSinglePlayerArg)./speed [walk|fly] <0-10>/speed [walk|fly] <0-10> <player>Tip
1is the vanilla speed and decimals such as1.5are allowed. Without a type, the fly speed is changed while flying, otherwise the walk speed.Notes
modules/basics-speed, picked up automatically bysettings.gradle.kts.messages.ymlusing the shared custom tags.0.5or1.5, parsed with core'sFloatRangeArg; values outside0-10get core's not-in-range error.FloatRangeArg); this branch is stacked on it, so the diff shows that commit until Add FloatArg and FloatRangeArg #180 is merged../gradlew :core:build :modules:basics-speed:build(compile + ktlint) passes locally on Java 17.