Repository navigation
Add FloatArg and FloatRangeArg - #180
Merged
Merged
Conversation
added 2 commits
October 14, 2026 16:57
Decimal counterparts to IntArg and IntRangeArg, with a must-be-a-number message and a float overload of the not-in-range message.
CommandArgument's default message already covers it, so the extra message key isn't needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds decimal counterparts to
IntArg/IntRangeArgso modules don't need their own float parsing (first user:/speedin #160).FloatArgNaN/Infinityare rejected); non-numbers get the default invalid-value messageFloatRangeArg(name, min, max)IntRangeArg: lambdas for the bounds, tab-completes them, and reports not in range for numbers outside themSupporting changes:
CoreMessages: aFloatoverload ofinvalidValueForArgumentNumberNotInRange, reusing the existing message key.FormatUtils:Float.toShortString(), so whole numbers show as10instead of10.0in that message and in completions.Testing
./gradlew :core:build(compile + ktlint + tests) passes on Java 17.