Repository navigation
TypewriterEffect: no 1 ms gap between steps - #316
Merged
Merged
Conversation
Each step ended 1 ms before the next one started, and the end-delay line started 1 ms after the last step. During each gap nothing is on screen, so the text flickered, and a Blu-ray sup exported with "Full frame image" let the video show through (SubtitleEdit/subtitleedit#15933). Each step now ends where the next one starts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flicker reported in SubtitleEdit/subtitleedit#15933.
Each typewriter step ended 1 ms before the next started (
endMs = ... - 1), and the end-delay line started 1 ms after the last step. During a gap nothing is on screen, so the text flickers. In the reporter's 23.976 fps Blu-ray sup with "Full frame image", 205 clears of 1 ms gave about 5 visible flashes where the video showed through.Verified: release build passes. A scratch harness running the engine on a 64-character line, with and without an end delay, gives 0 gaps, and the first start and last end are unchanged.
🤖 Generated with Claude Code