Skip to content

TypewriterEffect: no 1 ms gap between steps #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niksedk merged 1 commit into from
Oct 11, 2026
Merged

TypewriterEffect: no 1 ms gap between steps #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions se5/TypewriterEffect/TypewriterEngine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,11 @@ private static List<SrtBlock> GenerateForParagraph(SrtBlock p, double endDelaySe
text += tag + p.Text[i];
tag = string.Empty;

// Each step ends where the next one starts: a gap, even 1 ms, shows no text for
// that moment, so the line flickers (and a full-frame Blu-ray sup image lets the
// video show through).
var startMs = p.StartMs + (long)(index * stepMs);
var endMs = p.StartMs + (long)((index + 1) * stepMs) - 1;
var endMs = p.StartMs + (long)((index + 1) * stepMs);
if (endMs < startMs)
{
endMs = startMs;
Expand All @@ -165,7 +168,7 @@ private static List<SrtBlock> GenerateForParagraph(SrtBlock p, double endDelaySe

if (endDelayMs > 0 && result.Count > 0)
{
var startMs = p.StartMs + workDurationMs;
var startMs = result[^1].EndMs;
result.Add(new SrtBlock { StartMs = startMs, EndMs = p.EndMs, Text = p.Text });
}
else if (result.Count > 0)
Expand Down
Loading