Repository navigation
Plugins: follow the EBU STL frame rate a plugin sets in the header - #15793
Merged
Merged
Conversation
ArteCheck converts an STL30 file to 25 fps and returns an STL25.01 header. The file was then saved at 25 fps, but the toolbar frame rate stayed at 30, so the grid showed 30 fps frame numbers and frame mode snapped later edits to 30 fps frames. When a plugin changes the disk format code, the frame rate now follows it, like opening an STL file does. A loaded video still wins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
niksedk
added a commit
that referenced
this pull request
Oct 8, 2026
niksedk
added a commit
that referenced
this pull request
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #15791 (#15185).
Problem
ArteCheck converts an STL30 file to 25 fps and returns the header with disk format code
STL25.01. The save already follows the header (the writer reads the frame rate from the DFC), but the toolbar frame rate stayed at 30: the grid showed 30 fps frame numbers for 25 fps time codes, and frame mode snapped later manual edits to 30 fps frames.Fix
When a structured plugin response changes the EBU STL disk format code,
FollowEbuHeaderFrameRatesets the toolbar/current frame rate from it - the same thing opening an STL file does. Skipped when the DFC is unchanged, the rate already matches, or a video is loaded (the video's frame rate still wins, as on file open).ComboBoxFrameRateSelectionChanged's body moved toApplyCurrentFrameRateso both share it.Note: undoing the plugin step restores the STL30 header but not the toolbar frame rate (same as other frame-rate changes today).
Tests
StructuredResponse_Stl25Header_FollowsFrameRateUnlessVideo(no video → 25, video loaded → stays 30); fails without the change. Plugin/EBU/frame-rate UI tests: 233 passed.🤖 Generated with Claude Code