Skip to content

Alternating row contrast (%) setting for the subtitle grid - #16807

Closed
niksedk wants to merge 2 commits into
mainfrom
claude/subtitle-edit-16779-1e8150
Closed

niksedk wants to merge 2 commits into
mainfrom
claude/subtitle-edit-16779-1e8150

Conversation

@niksedk

@niksedk niksedk commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Fixes #16779.

Problem: With Use alternating row colors in grid on, the light-theme default (#F5F5F5 on white, ~4%) is so faint that it looks like the setting does nothing.

Change: Options > Settings > Appearance: the two color pickers (light/dark) are replaced by one Alternating row contrast (%) number, 4-20, default 10.

  • Row tint = theme background blended that percentage toward the theme text color, so it gets darker on light themes and lighter on dark ones.
  • Works for every theme, including Nord / Midnight Cinema / Sakura. They used to have hard-coded tints that the old settings didn't affect; now they keep their own hue and follow the percentage.
  • Settings saved with a custom alternating row color fall back to the 10% default, because the old keys are ignored on load.
  • Updates live on theme switch and when settings close (same brush as before).

At the default 10%: light #E6E6E6 (was #F5F5F5), dark ≈ #343434 on #212121 (was #2D2D2D).

Tests: GridAlternatingRowContrastTests (blend math, clamping, default).

🤖 Generated with Claude Code

niksedk and others added 2 commits November 10, 2026 13:04
The grid's alternating row tint is now the theme background moved 4-20%
(default 6%) toward the theme text color, instead of a fixed light/dark
color pair. The old light default (#F5F5F5 on white) was too faint to
notice (#16779), and the stripe now follows every theme's own tint.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6% (#F0F0F0 on white) was still hard to see on light themes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use alternating row colors in grid: suggested colour is the same as the foreground colour

1 participant