Repository navigation
Conversation
…the filter Clearing the filter re-selects the first row; today that is the preset, but if the fake engine ever lists a wav first its peak load would race the temp folder delete again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16808: this surfaced during the full-suite runs while verifying that PR.
VoiceManagerViewModelTests.FilterNarrowsTheListAndKeepsTheSelectionWhenItStillMatchesfailsintermittently with
System.IO.IOException: Bob.wav is being used by another processin itsfinally Directory.Delete(folder, true).Selecting the file voice "Bob" starts an async details load whose peak generation
(
WavePeakGenerator2) holds the wav open; the delete races that read. It reproducesdeterministically in isolated cold runs (10/10 failures) and passes in a warm full suite, which is
why it has only surfaced sporadically.
Fix:
await vm.DetailsLoaded;immediately after the selection, before any filter changes. Thatguarantees the stream is disposed before the temp folder is deleted. Placement matters: the later
filter resets re-select either
nullor the preset voice, both of which return before touching afile, so the selection's load is the only one that holds a handle - an await at the end of the test
would wait on the wrong task. No production code changes; the async details load is intended
behavior.
Verification: isolated runs 10/10 failures before, 10/10 passes after; full test class green.